optimize computing bounds by calling SkMatrix44::map2()

cc/math_util.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/math_util.h"
 
 #include <cmath>
 #include <limits>
 
 #include "ui/gfx/quad_f.h"
@@ skipping 91 matching lines @@
 
 gfx::Rect MathUtil::mapClippedRect(const gfx::Transform& transform, const gfx::Rect& srcRect)
 {
     return gfx::ToEnclosingRect(mapClippedRect(transform, gfx::RectF(srcRect)));
 }
 
 gfx::RectF MathUtil::mapClippedRect(const gfx::Transform& transform, const gfx::RectF& srcRect)
 {
     if (transform.IsIdentityOrTranslation())
         return srcRect + gfx::Vector2dF(static_cast<float>(transform.matrix().getDouble(0, 3)), static_cast<float>(transform.matrix().getDouble(1, 3)));
+    
+    // Apply the transform, but retain the result in homogeneous coordinates.
 
-    // Apply the transform, but retain the result in homogeneous coordinates.
-    gfx::QuadF q = gfx::QuadF(srcRect);
-    HomogeneousCoordinate h1 = mapHomogeneousPoint(transform, gfx::Point3F(q.p1()));
-    HomogeneousCoordinate h2 = mapHomogeneousPoint(transform, gfx::Point3F(q.p2()));
-    HomogeneousCoordinate h3 = mapHomogeneousPoint(transform, gfx::Point3F(q.p3()));
-    HomogeneousCoordinate h4 = mapHomogeneousPoint(transform, gfx::Point3F(q.p4()));
+    double quad[4 * 2]; // input: 4 x 2D points
+    quad[0] = srcRect.x();     quad[1] = srcRect.y();
+    quad[2] = srcRect.right(); quad[3] = srcRect.y();
+    quad[4] = srcRect.x();     quad[5] = srcRect.bottom();
+    quad[6] = srcRect.right(); quad[7] = srcRect.bottom();
 
-    return computeEnclosingClippedRect(h1, h2, h3, h4);
+    double result[4 * 4];   // output: 4 x 4D homogeneous points
+    transform.matrix().map2(quad, 4, result);
+
+    return computeEnclosingClippedRect(*(const HomogeneousCoordinate*)&result[0],

[jamesr, 2012/12/07 04:30:39]

chromium code never uses c-style casts.  I'd suggest hoisting the cast to result
out of this call and using a static_cast<>, if that compiles, or even better
just doing member-by-member initialization and trust the compiler to fold it
together.

+                                       *(const HomogeneousCoordinate*)&result[4],
+                                       *(const HomogeneousCoordinate*)&result[8],
+                                       *(const HomogeneousCoordinate*)&result[12]);
 }
 
 gfx::RectF MathUtil::projectClippedRect(const gfx::Transform& transform, const gfx::RectF& srcRect)
 {
     if (transform.IsIdentityOrTranslation())
         return srcRect + gfx::Vector2dF(static_cast<float>(transform.matrix().getDouble(0, 3)), static_cast<float>(transform.matrix().getDouble(1, 3)));
 
     // Perform the projection, but retain the result in homogeneous coordinates.
     gfx::QuadF q = gfx::QuadF(srcRect);
     HomogeneousCoordinate h1 = projectHomogeneousPoint(transform, q.p1());
@@ skipping 351 matching lines @@
     matrix.setDouble(1, 0, b);
     matrix.setDouble(0, 1, c);
     matrix.setDouble(1, 1, d);
     matrix.setDouble(0, 3, e);
     matrix.setDouble(1, 3, f);
 
     return result;
 }
 
 }  // namespace cc