Introduce a class encapsulating arguments descriptor arrays.

runtime/vm/code_generator.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 657 matching lines @@
 // Arg0: formal parameter index as Smi.
 // Arg1: formal parameter name as Symbol.
 // Arg2: arguments descriptor array.
 // Return value: true or false.
 DEFINE_RUNTIME_ENTRY(ArgumentDefinitionTest, 3) {
   ASSERT(arguments.ArgCount() ==
          kArgumentDefinitionTestRuntimeEntry.argument_count());
   const Smi& param_index = Smi::CheckedHandle(arguments.ArgAt(0));
   const String& param_name = String::CheckedHandle(arguments.ArgAt(1));
   ASSERT(param_name.IsSymbol());
-  const Array& arg_desc = Array::CheckedHandle(arguments.ArgAt(2));
-  const intptr_t num_pos_args = Smi::CheckedHandle(arg_desc.At(1)).Value();
+  ArgumentsDescriptor arg_desc(arguments.ArgAt(2));

[regis, 2012/12/05 18:39:24]

Why did you remove the CheckedHandle here and below?

[regis, 2012/12/05 18:39:24]

You cannot pass a raw object as parameter.

[Kevin Millikin (Google), 2012/12/05 19:11:23]

Here: it's not removed, the ArgumentsDescriptor constructor does CheckedHandle.

Below: because I couldn't figure out why it was there.  Without any
documentation, the best I could understand is that we use CheckedHandle on
arguments to runtime calls, but we rely on debug-only assertions for values we
read out of the heap with a known (expected) type.

If the rule is that all downcasts are checked also in release builds, I think we
have to change a lot of other code, too.

[srdjan, 2012/12/05 19:34:17]

We need to document when to use CheckedHandle (only in runtime and native
functions when transitioning from compiled code).

+  const intptr_t num_pos_args = arg_desc.PositionalCount();
   // Check if the formal parameter is defined by a positional argument.
   bool is_defined = num_pos_args > param_index.Value();
   if (!is_defined) {
     // Check if the formal parameter is defined by a named argument.
-    const intptr_t num_named_args =
-        Smi::CheckedHandle(arg_desc.At(0)).Value() - num_pos_args;
+    const intptr_t num_named_args = arg_desc.NamedCount();
     String& arg_name = String::Handle();
     for (intptr_t i = 0; i < num_named_args; i++) {
-      arg_name ^= arg_desc.At(2*i + 2);
+      arg_name ^= arg_desc.NameAt(i);
       if (arg_name.raw() == param_name.raw()) {
         is_defined = true;
         break;
       }
     }
   }
   arguments.SetReturn(Bool::Handle(Bool::Get(is_defined)));
 }
 
 
@@ skipping 1180 matching lines @@
   Isolate* isolate = Isolate::Current();
   StackZone zone(isolate);
   HANDLESCOPE(isolate);
   const Bigint& big_left = Bigint::Handle(left);
   const Bigint& big_right = Bigint::Handle(right);
   return BigintOperations::Compare(big_left, big_right);
 }
 END_LEAF_RUNTIME_ENTRY
 
 }  // namespace dart