Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1144193002: Enable more benchmark_smoke_unittest coverage (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable more benchmark_smoke_unittest coverage Previously, benchmark_smoke_unittest has a heuristic to pick a benchmark for smoke testing if the benchmark uses a test in measurement directory. This patch removes that check, and instead provide a black list of benchmarks module that we exclude the benchmark_smoke_unittest to avoid high CQ time. This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one in each benchmark module). On my local linux machine, this increases the cycle time of benchmark_smoke_unittest from 20s -> 1m7s. BUG=490130 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/65014162e48a7f5881e8b282dd9e8dc17c5aa7c4 Cr-Commit-Position: refs/heads/master@{#330909}

Patch Set 1 : #

Patch Set 2 : Blacklist rasterize_and_record_micro #

Patch Set 3 : Black list blink_perf #

Patch Set 4 : Blacklist dom_perf instead of blink_perf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 2 3 2 chunks +26 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
nednguyen
5 years, 7 months ago (2015-05-20 20:28:32 UTC) #5
dtu
lgtm
5 years, 7 months ago (2015-05-20 21:01:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144193002/80001
5 years, 7 months ago (2015-05-20 23:31:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-21 01:33:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144193002/80001
5 years, 7 months ago (2015-05-21 01:36:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/59657)
5 years, 7 months ago (2015-05-21 04:20:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144193002/100001
5 years, 7 months ago (2015-05-21 05:49:21 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 7 months ago (2015-05-21 07:07:30 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/65014162e48a7f5881e8b282dd9e8dc17c5aa7c4 Cr-Commit-Position: refs/heads/master@{#330909}
5 years, 7 months ago (2015-05-21 07:08:32 UTC) #20
battre
5 years, 7 months ago (2015-05-21 10:00:00 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/1143363006/ by battre@chromium.org.

The reason for reverting is: Reverting due to flaky perf tests (see
crbug.com/490130 for details)..

Powered by Google App Engine
This is Rietveld 408576698