Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/code-factory.cc

Issue 1144183004: [strong] Refactor ObjectStrength into a replacement for strong boolean args (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback and rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 10
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 Isolate* isolate, LanguageMode language_mode, 88 Isolate* isolate, LanguageMode language_mode,
89 InlineCacheState initialization_state) { 89 InlineCacheState initialization_state) {
90 return Callable(KeyedStoreIC::initialize_stub(isolate, language_mode, 90 return Callable(KeyedStoreIC::initialize_stub(isolate, language_mode,
91 initialization_state), 91 initialization_state),
92 StoreDescriptor(isolate)); 92 StoreDescriptor(isolate));
93 } 93 }
94 94
95 95
96 // static 96 // static
97 Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op, 97 Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op,
98 LanguageMode language_mode) { 98 Strength strength) {
99 Handle<Code> code = 99 Handle<Code> code = CompareIC::GetUninitialized(isolate, op, strength);
100 CompareIC::GetUninitialized(isolate, op, is_strong(language_mode));
101 return Callable(code, CompareDescriptor(isolate)); 100 return Callable(code, CompareDescriptor(isolate));
102 } 101 }
103 102
104 103
105 // static 104 // static
106 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op, 105 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op,
107 LanguageMode language_mode) { 106 Strength strength) {
108 BinaryOpICStub stub(isolate, op, language_mode); 107 BinaryOpICStub stub(isolate, op, strength);
109 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 108 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
110 } 109 }
111 110
112 111
113 // static 112 // static
114 Callable CodeFactory::ToBoolean(Isolate* isolate, 113 Callable CodeFactory::ToBoolean(Isolate* isolate,
115 ToBooleanStub::ResultMode mode, 114 ToBooleanStub::ResultMode mode,
116 ToBooleanStub::Types types) { 115 ToBooleanStub::Types types) {
117 ToBooleanStub stub(isolate, mode, types); 116 ToBooleanStub stub(isolate, mode, types);
118 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 117 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 173
175 // static 174 // static
176 Callable CodeFactory::CallFunction(Isolate* isolate, int argc, 175 Callable CodeFactory::CallFunction(Isolate* isolate, int argc,
177 CallFunctionFlags flags) { 176 CallFunctionFlags flags) {
178 CallFunctionStub stub(isolate, argc, flags); 177 CallFunctionStub stub(isolate, argc, flags);
179 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 178 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
180 } 179 }
181 180
182 } // namespace internal 181 } // namespace internal
183 } // namespace v8 182 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698