[strong] Refactor ObjectStrength into a replacement for strong boolean args

src/compiler/js-operator.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_JS_OPERATOR_H_
 #define V8_COMPILER_JS_OPERATOR_H_
 
 #include "src/runtime/runtime.h"
 #include "src/unique.h"
 
@@ skipping 307 matching lines @@
 // AST. Most operators have no parameters, thus can be globally shared for all
 // graphs.
 class JSOperatorBuilder final : public ZoneObject {
  public:
   explicit JSOperatorBuilder(Zone* zone);
 
   const Operator* Equal();
   const Operator* NotEqual();
   const Operator* StrictEqual();
   const Operator* StrictNotEqual();
-  const Operator* LessThan(LanguageMode language_mode);
-  const Operator* GreaterThan(LanguageMode language_mode);
-  const Operator* LessThanOrEqual(LanguageMode language_mode);
-  const Operator* GreaterThanOrEqual(LanguageMode language_mode);
-  const Operator* BitwiseOr(LanguageMode language_mode);
-  const Operator* BitwiseXor(LanguageMode language_mode);
-  const Operator* BitwiseAnd(LanguageMode language_mode);
-  const Operator* ShiftLeft(LanguageMode language_mode);
-  const Operator* ShiftRight(LanguageMode language_mode);
-  const Operator* ShiftRightLogical(LanguageMode language_mode);
-  const Operator* Add(LanguageMode language_mode);
-  const Operator* Subtract(LanguageMode language_mode);
-  const Operator* Multiply(LanguageMode language_mode);
-  const Operator* Divide(LanguageMode language_mode);
-  const Operator* Modulus(LanguageMode language_mode);
+  const Operator* LessThan(Strength strength);

[rossberg, 2015/06/08 11:34:21]

As discussed offline, on the abstraction level of the TF graph nodes/operators,
it seems preferable to stick to LanguageMode. Only lower to Strength where you
go from syntax to runtime/code.

[conradw, 2015/06/08 11:48:49]

Done.

+  const Operator* GreaterThan(Strength strength);
+  const Operator* LessThanOrEqual(Strength strength);
+  const Operator* GreaterThanOrEqual(Strength strength);
+  const Operator* BitwiseOr(Strength strength);
+  const Operator* BitwiseXor(Strength strength);
+  const Operator* BitwiseAnd(Strength strength);
+  const Operator* ShiftLeft(Strength strength);
+  const Operator* ShiftRight(Strength strength);
+  const Operator* ShiftRightLogical(Strength strength);
+  const Operator* Add(Strength strength);
+  const Operator* Subtract(Strength strength);
+  const Operator* Multiply(Strength strength);
+  const Operator* Divide(Strength strength);
+  const Operator* Modulus(Strength strength);
 
   const Operator* UnaryNot();
   const Operator* ToBoolean();
   const Operator* ToNumber();
   const Operator* ToString();
   const Operator* ToName();
   const Operator* ToObject();
   const Operator* Yield();
 
   const Operator* Create();
@@ skipping 57 matching lines @@
   Zone* const zone_;
 
   DISALLOW_COPY_AND_ASSIGN(JSOperatorBuilder);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_JS_OPERATOR_H_