Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1144173002: More efficient SkRecorder::flushMiniRecorder() (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More efficient SkRecorder::flushMiniRecorder() This should involve no mallocs, frees, or memcpys, and less refcounting. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d41ea1d1cf0358e8b147c30c2dd168b631cc9b47

Patch Set 1 #

Patch Set 2 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M src/core/SkMiniRecorder.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkMiniRecorder.cpp View 2 chunks +22 lines, -2 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144173002/1
5 years, 7 months ago (2015-05-20 16:38:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144173002/20001
5 years, 7 months ago (2015-05-20 16:42:31 UTC) #4
mtklein_C
5 years, 7 months ago (2015-05-20 16:42:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 16:48:46 UTC) #8
f(malita)
lgtm
5 years, 7 months ago (2015-05-20 17:14:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144173002/20001
5 years, 7 months ago (2015-05-20 17:16:12 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:16:53 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d41ea1d1cf0358e8b147c30c2dd168b631cc9b47

Powered by Google App Engine
This is Rietveld 408576698