Getting started on the fuzzer web front end.

Getting started on the fuzzer web front end.

Just a skeleton for now; getting more familiar with the facilities
provided by the infra common go/polymer elements (e.g., login).

BUG=skia:
R=jcgregorio

Committed: https://skia.googlesource.com/buildbot/+/4284c012b0d700f4c650c00d1ae1a9fd20e5a63c

[humper, 2015-05-28 20:24:11]

ptal

[jcgregorio, 2015-06-01 14:39:47]

May just be me, but that skia_fuzz.png image is going to give me a headache.

https://codereview.chromium.org/1144163010/diff/40001/fuzzer/templates/index....
File fuzzer/templates/index.html (right):

https://codereview.chromium.org/1144163010/diff/40001/fuzzer/templates/index....
fuzzer/templates/index.html:15: var page = {};
This looks good, but wrap it in the 'then' of the sk.WebComponentsReady()
Promise, which will ensure that Polymer is done initializing. The need for this
will go away with Polymer 1.0.


 https://github.com/google/skia-buildbot/blob/master/res/js/common.js#L204

https://codereview.chromium.org/1144163010/diff/40001/res/js/common.js
File res/js/common.js (right):

https://codereview.chromium.org/1144163010/diff/40001/res/js/common.js#newcod...
res/js/common.js:586: // return true iff the string starts with the given prefix
What is this? It's not a function?

[humper, 2015-06-01 16:14:43]

https://codereview.chromium.org/1144163010/diff/40001/fuzzer/templates/index....
File fuzzer/templates/index.html (right):

https://codereview.chromium.org/1144163010/diff/40001/fuzzer/templates/index....
fuzzer/templates/index.html:15: var page = {};
On 2015/06/01 14:39:47, jcgregorio wrote:
> This looks good, but wrap it in the 'then' of the sk.WebComponentsReady()
> Promise, which will ensure that Polymer is done initializing. The need for
this
> will go away with Polymer 1.0.
> 
> 
>  https://github.com/google/skia-buildbot/blob/master/res/js/common.js#L204

Done.

https://codereview.chromium.org/1144163010/diff/40001/res/js/common.js
File res/js/common.js (right):

https://codereview.chromium.org/1144163010/diff/40001/res/js/common.js#newcod...
res/js/common.js:586: // return true iff the string starts with the given prefix
On 2015/06/01 14:39:47, jcgregorio wrote:
> What is this? It's not a function?

Not sure what you mean -- I'm just checking here to make sure that the
"startsWith" function doesn't already exist before I install a new one.  Is
there another idiom for doing that?

[jcgregorio, 2015-06-01 16:34:15]

https://codereview.chromium.org/1144163010/diff/40001/res/js/common.js
File res/js/common.js (right):

https://codereview.chromium.org/1144163010/diff/40001/res/js/common.js#newcod...
res/js/common.js:586: // return true iff the string starts with the given prefix
On 2015/06/01 16:14:43, humper wrote:
> On 2015/06/01 14:39:47, jcgregorio wrote:
> > What is this? It's not a function?
> 
> Not sure what you mean -- I'm just checking here to make sure that the
> "startsWith" function doesn't already exist before I install a new one.  Is
> there another idiom for doing that?

OK, yeah, so if you are just polyfilling String.startsWith, add a comment to
that effect. You might also want to look at:


https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

[humper, 2015-06-01 17:32:10]

done

[jcgregorio, 2015-06-01 17:37:01]

lgtm

[humper, 2015-06-01 18:12:52]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2015-06-01 18:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144163010/80001

[commit-bot: I haz the power, 2015-06-01 18:14:56]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/buildbot/+/4284c012b0d700f4c650c00d1ae1a9fd20e5...