pkg/compiler/lib/src/js_backend/codegen/unsugar.dart - Issue 1144163004: dart2js cps: Always use interceptors and type tags for 'is' checks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 1144163004: dart2js cps: Always use interceptors and type tags for 'is' checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Rebase + status file Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 library dart2js.unsugar_cps;	1 library dart2js.unsugar_cps;

2	2

3 import '../../cps_ir/cps_ir_nodes.dart';	3 import '../../cps_ir/cps_ir_nodes.dart';

4	4

5 // TODO(karlklose): share the [ParentVisitor].	5 // TODO(karlklose): share the [ParentVisitor].

6 import '../../cps_ir/optimizers.dart';	6 import '../../cps_ir/optimizers.dart';

7 import '../../constants/expressions.dart';	7 import '../../constants/expressions.dart';

8 import '../../constants/values.dart';	8 import '../../constants/values.dart';

9 import '../../elements/elements.dart' show	9 import '../../elements/elements.dart' show

10 ClassElement,	10 ClassElement,

(...skipping 274 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
285 LetPrim newNode = new LetPrim(t,	285 LetPrim newNode = new LetPrim(t,

286 new LetPrim(i,	286 new LetPrim(i,

287 new Branch(new IsTrue(i),	287 new Branch(new IsTrue(i),

288 node.trueContinuation.definition,	288 node.trueContinuation.definition,

289 node.falseContinuation.definition)));	289 node.falseContinuation.definition)));

290 condition.value.unlink();	290 condition.value.unlink();

291 node.trueContinuation.unlink();	291 node.trueContinuation.unlink();

292 node.falseContinuation.unlink();	292 node.falseContinuation.unlink();

293 parent.body = newNode;	293 parent.body = newNode;

294 }	294 }

	295

	296 processInterceptor(Interceptor node) {

	297 _glue.registerSpecializedGetInterceptor(node.interceptedClasses);

	298 }

295 }	299 }

OLD	NEW