Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/glue.dart

Issue 1144163004: dart2js cps: Always use interceptors and type tags for 'is' checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Long line Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_generator_dependencies; 5 library code_generator_dependencies;
6 6
7 import '../js_backend.dart'; 7 import '../js_backend.dart';
8 import '../../dart2jslib.dart'; 8 import '../../dart2jslib.dart';
9 import '../../js_emitter/js_emitter.dart'; 9 import '../../js_emitter/js_emitter.dart';
10 import '../../js/js.dart' as js; 10 import '../../js/js.dart' as js;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 } 105 }
106 106
107 Set<ClassElement> getInterceptedClassesOn(Selector selector) { 107 Set<ClassElement> getInterceptedClassesOn(Selector selector) {
108 return _backend.getInterceptedClassesOn(selector.name); 108 return _backend.getInterceptedClassesOn(selector.name);
109 } 109 }
110 110
111 void registerSpecializedGetInterceptor(Set<ClassElement> classes) { 111 void registerSpecializedGetInterceptor(Set<ClassElement> classes) {
112 _backend.registerSpecializedGetInterceptor(classes); 112 _backend.registerSpecializedGetInterceptor(classes);
113 } 113 }
114 114
115 Set<ClassElement> get interceptedClasses => _backend.interceptedClasses;
116
115 js.Expression constructorAccess(ClassElement element) { 117 js.Expression constructorAccess(ClassElement element) {
116 return _backend.emitter.constructorAccess(element); 118 return _backend.emitter.constructorAccess(element);
117 } 119 }
118 120
119 String instanceFieldPropertyName(Element field) { 121 String instanceFieldPropertyName(Element field) {
120 return _namer.instanceFieldPropertyName(field); 122 return _namer.instanceFieldPropertyName(field);
121 } 123 }
122 124
123 String instanceMethodName(FunctionElement element) { 125 String instanceMethodName(FunctionElement element) {
124 return _namer.instanceMethodName(element); 126 return _namer.instanceMethodName(element);
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 js.Expression generateTypeRepresentation(DartType dartType, 194 js.Expression generateTypeRepresentation(DartType dartType,
193 List<js.Expression> arguments) { 195 List<js.Expression> arguments) {
194 int variableIndex = 0; 196 int variableIndex = 0;
195 js.Expression representation = _backend.rti.getTypeRepresentation( 197 js.Expression representation = _backend.rti.getTypeRepresentation(
196 dartType, 198 dartType,
197 (_) => arguments[variableIndex++]); 199 (_) => arguments[variableIndex++]);
198 assert(variableIndex == arguments.length); 200 assert(variableIndex == arguments.length);
199 return representation; 201 return representation;
200 } 202 }
201 203
202 bool isNativePrimitiveType(DartType type) {
203 if (type is! InterfaceType) return false;
204 return _backend.isNativePrimitiveType(type.element);
205 }
206
207 void registerIsCheck(DartType type, Registry registry) { 204 void registerIsCheck(DartType type, Registry registry) {
208 _enqueuer.registerIsCheck(type, registry); 205 _enqueuer.registerIsCheck(type, registry);
209 _backend.registerIsCheckForCodegen(type, _enqueuer, registry); 206 _backend.registerIsCheckForCodegen(type, _enqueuer, registry);
210 } 207 }
211 208
212 bool isIntClass(ClassElement cls) => cls == _compiler.intClass;
213
214 bool isStringClass(ClassElement cls) => cls == _compiler.stringClass;
215
216 bool isBoolClass(ClassElement cls) => cls == _compiler.boolClass;
217
218 bool isNumClass(ClassElement cls) => cls == _compiler.numClass;
219
220 bool isDoubleClass(ClassElement cls) => cls == _compiler.doubleClass;
221
222 String getTypeTestTag(DartType type) { 209 String getTypeTestTag(DartType type) {
223 return _backend.namer.operatorIsType(type); 210 return _backend.namer.operatorIsType(type);
224 } 211 }
225 212
226 bool operatorEqHandlesNullArgument(FunctionElement element) { 213 bool operatorEqHandlesNullArgument(FunctionElement element) {
227 return _backend.operatorEqHandlesNullArgument(element); 214 return _backend.operatorEqHandlesNullArgument(element);
228 } 215 }
229
230 bool isListClass(ClassElement cls) => cls == _compiler.listClass;
231 } 216 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698