Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 1144163002: Revert of Use shared container to manage imports/exports. (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use shared container to manage imports/exports. (patchset #2 id:20001 of https://codereview.chromium.org/1143993003/) Reason for revert: Breaks nosnap bots Original issue's description: > Use shared container to manage imports/exports. > > Also changed string.js and math.js to adapt this change. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd > Cr-Commit-Position: refs/heads/master@{#28521} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1ec55616854380350e8f7f29dc5a5eb7bd9ecec5 Cr-Commit-Position: refs/heads/master@{#28523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -449 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/array.js View 3 chunks +4 lines, -10 lines 0 comments Download
M src/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/arraybuffer.js View 2 chunks +5 lines, -17 lines 0 comments Download
M src/bootstrapper.cc View 10 chunks +40 lines, -38 lines 0 comments Download
M src/collection.js View 1 chunk +1 line, -1 line 0 comments Download
M src/collection-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/date.js View 5 chunks +6 lines, -14 lines 0 comments Download
M src/generator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-array.js View 2 chunks +13 lines, -24 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-spread.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.js View 49 chunks +85 lines, -94 lines 0 comments Download
M src/iterator-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 3 chunks +3 lines, -11 lines 0 comments Download
M src/math.js View 3 chunks +14 lines, -12 lines 0 comments Download
M src/messages.js View 7 chunks +8 lines, -18 lines 0 comments Download
M src/object-observe.js View 2 chunks +2 lines, -2 lines 0 comments Download
D src/prologue.js View 1 chunk +0 lines, -57 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 6 chunks +13 lines, -22 lines 0 comments Download
M src/string-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/symbol.js View 1 chunk +1 line, -1 line 0 comments Download
M src/templates.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 8 chunks +13 lines, -24 lines 0 comments Download
M src/typedarray.js View 2 chunks +7 lines, -21 lines 0 comments Download
M src/uri.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 4 chunks +4 lines, -12 lines 0 comments Download
M src/weak-collection.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +31 lines, -43 lines 0 comments Download
A test/mjsunit/regress/regress-1878.js View 1 chunk +44 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Created Revert of Use shared container to manage imports/exports.
5 years, 7 months ago (2015-05-20 15:59:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144163002/1
5 years, 7 months ago (2015-05-20 15:59:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 16:00:00 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 16:00:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ec55616854380350e8f7f29dc5a5eb7bd9ecec5
Cr-Commit-Position: refs/heads/master@{#28523}

Powered by Google App Engine
This is Rietveld 408576698