Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1144153007: Fallback bitmap devices should observe the computed pixel geometry (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fallback bitmap devices should observe the computed pixel geometry When onCreateDevice() fails, internalSaveLayer() attempts to create a fallback bitmap device instead - but it ignores the computed pixel geometry in this case. BUG=496054 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/8804f589167a3e340d25ee1226aa71eb8a2ae930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkCanvas.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
f(malita)
5 years, 6 months ago (2015-06-04 05:38:14 UTC) #1
reed1
lgtm
5 years, 6 months ago (2015-06-04 14:13:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144153007/1
5 years, 6 months ago (2015-06-04 14:43:58 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 14:52:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8804f589167a3e340d25ee1226aa71eb8a2ae930

Powered by Google App Engine
This is Rietveld 408576698