components/password_manager/core/browser/password_store_unittest.cc - Issue 1144153004: components: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 1144153004: components: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_default_unittest.cc ('k') | components/password_manager/core/browser/test_password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc

index ba4140bb70088014d7a30d74a1374f71a314352a..a45fce86c1543237ff29381a1f49dd1314134b53 100644

--- a/components/password_manager/core/browser/password_store_unittest.cc

+++ b/components/password_manager/core/browser/password_store_unittest.cc

@@ -158,7 +158,7 @@ ACTION(STLDeleteElements0) {

TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

- base::MessageLoopProxy::current(), base::MessageLoopProxy::current(),

+ base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

make_scoped_ptr(new LoginDatabase(test_login_db_file_path()))));

store->Init(syncer::SyncableService::StartSyncFlare());

@@ -282,7 +282,7 @@ TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {

TEST_F(PasswordStoreTest, StartSyncFlare) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

- base::MessageLoopProxy::current(), base::MessageLoopProxy::current(),

+ base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

make_scoped_ptr(new LoginDatabase(test_login_db_file_path()))));

StartSyncFlareMock mock;

store->Init(

@@ -378,7 +378,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithoutAffiliations) {

/* clang-format on */

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

- base::MessageLoopProxy::current(), base::MessageLoopProxy::current(),

+ base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

make_scoped_ptr(new LoginDatabase(test_login_db_file_path()))));

store->Init(syncer::SyncableService::StartSyncFlare());

@@ -474,7 +474,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {

/* clang-format on */

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

- base::MessageLoopProxy::current(), base::MessageLoopProxy::current(),

+ base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

make_scoped_ptr(new LoginDatabase(test_login_db_file_path()))));

store->Init(syncer::SyncableService::StartSyncFlare());