components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc - Issue 1144153004: components: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

Issue 1144153004: components: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/renderer/ppb_nacl_private_impl.cc ('k') | components/password_manager/core/browser/mock_password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

index 56452f496916367321cd7a2ff383b5f4ab3e3634..b6258411f765e24c6050b24af6191b6c11349e02 100644

--- a/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

@@ -11,6 +11,7 @@

#include "base/run_loop.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/thread_task_runner_handle.h"

#include "components/password_manager/content/common/credential_manager_messages.h"

#include "components/password_manager/core/browser/credential_manager_password_form_manager.h"

#include "components/password_manager/core/browser/stub_password_manager_client.h"

@@ -83,8 +84,8 @@ class MockPasswordManagerClient

local_forms.empty()

? password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED

: password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);

- base::MessageLoop::current()->PostTask(FROM_HERE,

- base::Bind(callback, info));

+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,

+ base::Bind(callback, info));

PromptUserToChooseCredentialsPtr(local_forms.get(), federated_forms.get(),

origin, callback);

return true;