components/captive_portal/captive_portal_detector_unittest.cc - Issue 1144153004: components: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/captive_portal/captive_portal_detector_unittest.cc

Issue 1144153004: components: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_watcher/window_hang_monitor_win_unittest.cc ('k') | components/component_updater/default_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/captive_portal/captive_portal_detector_unittest.cc

diff --git a/components/captive_portal/captive_portal_detector_unittest.cc b/components/captive_portal/captive_portal_detector_unittest.cc

index 25eb35c1e373720d0e35e029a48cd23321d6246d..bff38212bfb6bf3f933fd59793d2c09855b6ff95 100644

--- a/components/captive_portal/captive_portal_detector_unittest.cc

+++ b/components/captive_portal/captive_portal_detector_unittest.cc

@@ -8,8 +8,8 @@

#include "base/bind.h"

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

-#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

+#include "base/thread_task_runner_handle.h"

#include "base/time/time.h"

#include "components/captive_portal/captive_portal_testing_utils.h"

#include "net/base/net_errors.h"

@@ -55,10 +55,9 @@ class CaptivePortalDetectorTest : public testing::Test,

~CaptivePortalDetectorTest() override {}

void SetUp() override {

- CHECK(base::MessageLoopProxy::current().get());

scoped_refptr<net::URLRequestContextGetter> request_context_getter(

new net::TestURLRequestContextGetter(

- base::MessageLoopProxy::current()));

+ base::ThreadTaskRunnerHandle::Get()));

detector_.reset(new CaptivePortalDetector(request_context_getter.get()));

set_detector(detector_.get());