Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 1144143005: X87: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] First step towards sanitizing for-in and making it optimizable. port e2e47f30be06e6ea6b8a3cc90138381914ecd07d (r28711) original commit message: [turbofan] First step towards sanitizing for-in and making it optimizable. In a nutshell: The FILTER_KEY builtin is gone, and was replaced by a simple runtime call to ForInFilter, which does everything and is even cheaper (because FILTER_KEY used to call into the runtime anyway). And ForInFilter returns either the name or undefined, which makes it possible to remove the control flow construction from the AstGraphBuilder, and thereby make both the initialization and the per-loop code of for-in optimizable later (in typed lowering). BUG= Committed: https://crrev.com/388429e97c84a1320eef37cf6b5b26cb8e6ad3e0 Cr-Commit-Position: refs/heads/master@{#28748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 6 months ago (2015-06-01 10:26:14 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-02 08:42:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144143005/1
5 years, 6 months ago (2015-06-02 08:42:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 09:07:17 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 09:07:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/388429e97c84a1320eef37cf6b5b26cb8e6ad3e0
Cr-Commit-Position: refs/heads/master@{#28748}

Powered by Google App Engine
This is Rietveld 408576698