Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 114413005: Move page/Settings.* to frame/ (Closed)

Created:
7 years ago by eseidel
Modified:
7 years ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, rwlbuis, Nils Barth (inactive), blink-layers+watch_chromium.org, caseq+blink_chromium.org, Nate Chapin, arv+blink, bemjb+rendering_chromium.org, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, Inactive, kenneth.christiansen, nessy, loislo+blink_chromium.org, zoltan1, philipj_slow, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, darktears, haraken, krit, kojih, vcarbune.chromium, gavinp+prerender_chromium.org, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, gasubic, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Visibility:
Public.

Description

Move page/Settings.* to frame/ Settings no longer depends on Page, with the exception of one remaining bug with the inspector: http://crbug.com/327476 page/Settings was by far the largest remaining layering violation from core/ code up into page/ but there are still several others to untangle. TBR=abarth@chromium.org BUG=305811 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -698 lines) Patch
Source/bindings/v8/BindingSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/bindings/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
Source/core/core.gypi View 1 chunk +1 line, -1 line 0 comments Download
Source/core/core_derived_sources.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/CSSParser-in.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/CSSParserMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/FontSize.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/resolver/FontBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/FullscreenElementStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/ScriptableDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/Caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/SpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/editing/TextCheckingHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/events/NavigatorEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/Screen.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/Settings.h View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/frame/Settings.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/frame/Settings.in View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/frame/SettingsDelegate.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLAppletElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLMetaElement-in.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/forms/PasswordInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/parser/HTMLParserOptions.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/parser/XSSAuditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/DocumentWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/LinkLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/MixedContentChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/loader/TextResourceDecoderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/CreateWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/Settings.h View 1 chunk +0 lines, -115 lines 0 comments Download
Source/core/page/Settings.cpp View 1 chunk +0 lines, -177 lines 0 comments Download
Source/core/page/Settings.in View 1 chunk +0 lines, -289 lines 0 comments Download
Source/core/page/SpatialNavigation.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/FastTextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/InlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/RenderTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/testing/InspectorFrontendClientLocal.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/testing/InternalSettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/timing/MemoryInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/modules/webdatabase/DatabaseContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/modules/websockets/WebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/ApplicationCacheHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/InspectorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/PageOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/PopupMenuChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/SpellCheckerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebHelperPluginImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebKit.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebSettingsImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebSocketImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/tests/ViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/web/tests/WebViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
I tested both incremental and clean builds and ran the tests.
7 years ago (2013-12-12 23:27:00 UTC) #1
eseidel
Committed patchset #1 manually as r163824 (presubmit successful).
7 years ago (2013-12-12 23:35:04 UTC) #2
Dirk Pranke
7 years ago (2013-12-12 23:37:55 UTC) #3
Message was sent while issue was closed. 
On 2013/12/12 23:35:04, eseidel wrote:
> Committed patchset #1 manually as r163824 (presubmit successful).

rubber-stamp lgtm (though I'm not abarth).

Powered by Google App Engine
This is Rietveld 408576698