Issue 11441034: Remove SlidingStateWindow and related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11441034: Remove SlidingStateWindow and related code. (Closed)

Created:
8 years ago by Sven Panne

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove SlidingStateWindow and related code. Committed: http://code.google.com/p/v8/source/detail?r=13172

Patch Set 1 #

Patch Set 2 : Removed useless RuntimeProfiler::IsEnabled() checks. Rebased. #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : rebased #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -169 lines)			Patch
M	include/v8.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/flag-definitions.h	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/log.h	View		4 chunks	+0 lines, -9 lines	0 comments	Download
M	src/log.cc	View	1	10 chunks	+3 lines, -105 lines	0 comments	Download
M	src/v8-counters.h	View		2 chunks	+0 lines, -16 lines	0 comments	Download
M	src/v8-counters.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/v8globals.h	View		1 chunk	+6 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years ago (2012-12-07 13:26:11 UTC) #2

LGTM.

https://codereview.chromium.org/11441034/diff/3001/src/v8globals.h
File src/v8globals.h (left):

https://codereview.chromium.org/11441034/diff/3001/src/v8globals.h#oldcode363
src/v8globals.h:363: #define DEF_STATE_TAG(name) name,
This iz teh most awesomest macro evar.

Expand Messages | Collapse Messages