Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1144103006: gpu: Avoid scissor test for glCopyTextureCHROMIUM if possible. (Closed)

Created:
5 years, 6 months ago by dshwang
Modified:
5 years, 6 months ago
Reviewers:
reveman, no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Avoid scissor test for glCopyTextureCHROMIUM if possible. It's expensive to change scissor states, so avoid it if possible. In addition, the meaning of (x|y)offset in DoCopySubTexture and DoCopyTextureInternal are different. It's hard to understand. Make arguments of DoCopyTextureInternal() same to them of DoCopySubTexture(). BUG=490889 Committed: https://crrev.com/fcf4d38c170e6aeafe4707b63bd1809d6eefb882 Cr-Commit-Position: refs/heads/master@{#333215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 6 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dshwang
piman, sievers, could you review this small optimization? it's follow-up of reveman's https://codereview.chromium.org/1143373004/
5 years, 6 months ago (2015-06-05 13:49:56 UTC) #2
reveman
lgtm
5 years, 6 months ago (2015-06-05 15:38:24 UTC) #3
no sievers
lgtm
5 years, 6 months ago (2015-06-05 19:42:08 UTC) #4
piman
lgtm
5 years, 6 months ago (2015-06-05 19:57:02 UTC) #5
dshwang
thx for reviewing!
5 years, 6 months ago (2015-06-06 07:31:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144103006/1
5 years, 6 months ago (2015-06-06 07:31:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-06 07:34:15 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 07:34:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcf4d38c170e6aeafe4707b63bd1809d6eefb882
Cr-Commit-Position: refs/heads/master@{#333215}

Powered by Google App Engine
This is Rietveld 408576698