Issue 1144103004: Fix missing print command in a GN error case.

Issue 1144103004: Fix missing print command in a GN error case. (Closed)

Created:
5 years, 7 months ago by brettw

Modified:
5 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix missing print command in a GN error case. This mistake resulted in the error never getting reported. Committed: https://crrev.com/81d969a7fef4a51875a770e051780192a1903db6 Cr-Commit-Position: refs/heads/master@{#331182}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/gn/commands.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (4 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144103004/1

5 years, 7 months ago (2015-05-22 20:37:53 UTC) #4

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 7 months ago (2015-05-22 20:55:58 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144103004/1

5 years, 7 months ago (2015-05-22 21:39:06 UTC) #9

commit-bot: I haz the power

5 years, 7 months ago (2015-05-22 21:45:39 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/81d969a7fef4a51875a770e051780192a1903db6
Cr-Commit-Position: refs/heads/master@{#331182}