[Sync] Add support for loading, updating and querying delete journals in

sync/syncable/mutable_entry.cc

Index: sync/syncable/mutable_entry.cc
diff --git a/sync/syncable/mutable_entry.cc b/sync/syncable/mutable_entry.cc
index 5090ad1a9116739a00d89ae6f6952ec9c765acaa..bf051c623447457749ed098305e9ebc730448db7 100644
--- a/sync/syncable/mutable_entry.cc
+++ b/sync/syncable/mutable_entry.cc
@@ -273,9 +273,13 @@ bool MutableEntry::Put(ProtoField field,
 bool MutableEntry::Put(BitField field, bool value) {
   DCHECK(kernel_);
   write_transaction_->SaveOriginal(kernel_);
-  if (kernel_->ref(field) != value) {
+  bool old_value = kernel_->ref(field);
+  if (old_value != value) {
     kernel_->put(field, value);
     kernel_->mark_dirty(GetDirtyIndexHelper());
+
+    if (field == SERVER_IS_DEL)

[tim (not reviewing), 2012/12/13 02:48:10]

This can't be IS_DEL (and hence live in PutIsDel) I presume... can you explain /
comment why?

[haitaol1, 2012/12/13 21:34:21]

I think it's more accurate to use SERVER_IS_DEL to decide the status of an
entry. There are several early returns on the path from where SERVER_IS_DEL's
updated to where IS_DEL's updated. I'm concerned that we may not get update of
IS_DEL and leave or miss entries in delete journal accidentally.

On 2012/12/13 02:48:10, timsteele wrote:

+      dir()->UpdateDeleteJournals(write_transaction(), old_value, kernel_);
   }
   return true;
 }