Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: runtime/vm/dart_entry.cc

Issue 11441021: Pass handles not raw objects into methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
===================================================================
--- runtime/vm/dart_entry.cc (revision 15741)
+++ runtime/vm/dart_entry.cc (working copy)
@@ -119,8 +119,8 @@
}
-ArgumentsDescriptor::ArgumentsDescriptor(RawObject* array)
- : array_(Array::CheckedHandle(array)) {
+ArgumentsDescriptor::ArgumentsDescriptor(const Array& array)
+ : array_(array) {
}
@@ -134,10 +134,12 @@
}
-RawObject* ArgumentsDescriptor::NameAt(intptr_t index) const {
- return array_.At(kFirstNamedEntryIndex +
- (index * kNamedEntrySize) +
- kNameOffset);
+RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
+ String& result = String::Handle();
+ result ^= array_.At(kFirstNamedEntryIndex +
+ (index * kNamedEntrySize) +
+ kNameOffset);
siva 2012/12/05 19:18:48 const String& result = String::CheckedHandle(array
srdjan 2012/12/05 19:30:07 Discussed, ignoring.
+ return result.raw();
}
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698