Pass handles not raw objects into methods.

runtime/vm/dart_entry.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_entry.h"
 
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
 #include "vm/object_store.h"
 #include "vm/resolver.h"
@@ skipping 101 matching lines @@
   ASSERT(context.isolate() == Isolate::Current());
   const Code& code = Code::Handle(function.CurrentCode());
   ASSERT(!code.IsNull());
   const Array& arg_descriptor =
       Array::Handle(ArgumentsDescriptor::New(num_arguments,
                                              optional_arguments_names));
   return entrypoint(code.EntryPoint(), arg_descriptor, args.data(), context);
 }
 
 
-ArgumentsDescriptor::ArgumentsDescriptor(RawObject* array)
-    : array_(Array::CheckedHandle(array)) {
+ArgumentsDescriptor::ArgumentsDescriptor(const Array& array)
+    : array_(array) {
 }
 
 
 intptr_t ArgumentsDescriptor::Count() const {
   return Smi::CheckedHandle(array_.At(kCountIndex)).Value();
 }
 
 
 intptr_t ArgumentsDescriptor::PositionalCount() const {
   return Smi::CheckedHandle(array_.At(kPositionalCountIndex)).Value();
 }
 
 
-RawObject* ArgumentsDescriptor::NameAt(intptr_t index) const {
-  return array_.At(kFirstNamedEntryIndex +
-                   (index * kNamedEntrySize) +
-                   kNameOffset);
+RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
+  String& result = String::Handle();
+  result ^= array_.At(kFirstNamedEntryIndex +
+                      (index * kNamedEntrySize) +
+                      kNameOffset);

[siva, 2012/12/05 19:18:48]

const String& result = String::CheckedHandle(array_At(...));
return result.raw();

maybe ?

[srdjan, 2012/12/05 19:30:07]

Discussed, ignoring.

+  return result.raw();
 }
 
 
 intptr_t ArgumentsDescriptor::count_offset() {
   return Array::data_offset() + (kCountIndex * kWordSize);
 }
 
 
 intptr_t ArgumentsDescriptor::positional_count_offset() {
   return Array::data_offset() + (kPositionalCountIndex * kWordSize);
@@ skipping 208 matching lines @@
   const String& func_name = String::Handle(Field::GetterName(field_name));
   const Function& func = Function::Handle(cls.LookupDynamicFunction(func_name));
   ASSERT(!func.IsNull());
   GrowableArray<const Object*> arguments;
   const Array& kNoArgumentNames = Array::Handle();
   return DartEntry::InvokeDynamic(port, func, arguments, kNoArgumentNames);
 }
 
 
 }  // namespace dart