Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Correct structness Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index da9ec6a141138688a1d08193910359f72c34b98e..fcee6a2cc32e4c453db2d7e02745869264c8da3c 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -78,18 +78,17 @@ bool CodeStubGraphBuilderBase::BuildGraph() {
set_current_block(next_block);
int major_key = stub()->MajorKey();
- CodeStubInterfaceDescriptor** descriptors =
- info_.isolate()->code_stub_interface_descriptors();
- if (descriptors[major_key] == NULL) {
- descriptors[major_key] = stub()->GetInterfaceDescriptor(info_.isolate());
+ CodeStubInterfaceDescriptor* descriptor =
+ info_.isolate()->code_stub_interface_descriptor(major_key);
+ if (descriptor->register_param_count_ < 0) {
+ stub()->InitializeInterfaceDescriptor(info_.isolate(),
+ descriptor);
Jakob Kummerow 2012/12/05 16:14:33 nit: fits on one line?
danno 2012/12/05 16:16:51 Done.
}
-
- CodeStubInterfaceDescriptor* descriptor = descriptors[major_key];
- parameters_.Reset(new HParameter*[descriptor->number_of_register_params]);
+ parameters_.Reset(new HParameter*[descriptor->register_param_count_]);
HGraph* graph = this->graph();
Zone* zone = this->zone();
- for (int i = 0; i < descriptor->number_of_register_params; ++i) {
+ for (int i = 0; i < descriptor->register_param_count_; ++i) {
HParameter* param = new(zone) HParameter(i);
AddInstruction(param);
graph->start_environment()->Push(param);

Powered by Google App Engine
This is Rietveld 408576698