Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/deoptimizer-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2113 matching lines...) Expand 10 before | Expand all | Expand 10 after
2124 2124
2125 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) { 2125 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {
2126 LParameter* result = new(zone()) LParameter; 2126 LParameter* result = new(zone()) LParameter;
2127 if (info()->IsOptimizing()) { 2127 if (info()->IsOptimizing()) {
2128 int spill_index = chunk()->GetParameterStackSlot(instr->index()); 2128 int spill_index = chunk()->GetParameterStackSlot(instr->index());
2129 return DefineAsSpilled(result, spill_index); 2129 return DefineAsSpilled(result, spill_index);
2130 } else { 2130 } else {
2131 ASSERT(info()->IsStub()); 2131 ASSERT(info()->IsStub());
2132 CodeStubInterfaceDescriptor* descriptor = 2132 CodeStubInterfaceDescriptor* descriptor =
2133 info()->code_stub()->GetInterfaceDescriptor(info()->isolate()); 2133 info()->code_stub()->GetInterfaceDescriptor(info()->isolate());
2134 Register reg = descriptor->register_params[instr->index()]; 2134 Register reg = descriptor->register_params_[instr->index()];
2135 return DefineFixed(result, reg); 2135 return DefineFixed(result, reg);
2136 } 2136 }
2137 } 2137 }
2138 2138
2139 2139
2140 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) { 2140 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
2141 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width. 2141 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.
2142 if (spill_index > LUnallocated::kMaxFixedIndex) { 2142 if (spill_index > LUnallocated::kMaxFixedIndex) {
2143 Abort("Too many spill slots needed for OSR"); 2143 Abort("Too many spill slots needed for OSR");
2144 spill_index = 0; 2144 spill_index = 0;
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
2309 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2309 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2310 LOperand* object = UseRegister(instr->object()); 2310 LOperand* object = UseRegister(instr->object());
2311 LOperand* index = UseTempRegister(instr->index()); 2311 LOperand* index = UseTempRegister(instr->index());
2312 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2312 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2313 } 2313 }
2314 2314
2315 2315
2316 } } // namespace v8::internal 2316 } } // namespace v8::internal
2317 2317
2318 #endif // V8_TARGET_ARCH_X64 2318 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/deoptimizer-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698