content/browser/renderer_host/pepper/pepper_utils.h - Issue 11441012: PPB_UDPSocket_Private is switched to the new Pepper proxy.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/renderer_host/pepper/pepper_utils.h

Issue 11441012: PPB_UDPSocket_Private is switched to the new Pepper proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/renderer_host/pepper/pepper_udp_socket_private_host.h ('K') | « content/browser/renderer_host/pepper/pepper_udp_socket_private_shared.cc ('k') | content/browser/renderer_host/pepper/pepper_utils.cc » ('j') | ppapi/proxy/ppapi_messages.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UTILS_H_

	6 #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UTILS_H_

	7

	8 #include "content/public/common/process_type.h"

	9 #include "content/public/common/socket_permission_request.h"

	10

	11 struct PP_NetAddress_Private;

	12

	13 namespace content {

	14

	15 class RenderViewHost;

	16

	17 class PepperUtils {
	dmichael (off chromium) 2012/12/12 23:23:38 This is a pretty generic class name for something This is a pretty generic class name for something socket specific... is this going to be used for more than UDP? Maybe TCP? If it's only needed in UDP, I don't see a need to separate it out. If it will be used elsewhere... how about PepperSocketUtils, or something? ygorshenin1 2012/12/18 12:07:16 Done. Show quoted text On 2012/12/12 23:23:38, dmichael wrote: > This is a pretty generic class name for something socket specific... is this > going to be used for more than UDP? Maybe TCP? > > If it's only needed in UDP, I don't see a need to separate it out. If it will be > used elsewhere... how about PepperSocketUtils, or something? Done.
	18 public:

	19 static SocketPermissionRequest CreateSocketPermissionRequest(

	20 SocketPermissionRequest::OperationType type,

	21 const PP_NetAddress_Private& net_addr);

	22

	23 static bool CanUseSocketAPIs(ProcessType plugin_process_type,

	24 const SocketPermissionRequest& params,

	25 RenderViewHost* render_view_host);

	26 };
	dmichael (off chromium) 2012/12/12 23:23:38 If you do need this class, make sure to declare (b If you do need this class, make sure to declare (but don't implement) a private constructor. Or... just use a namespace instead of a class? ygorshenin1 2012/12/18 12:07:16 Done. Show quoted text On 2012/12/12 23:23:38, dmichael wrote: > If you do need this class, make sure to declare (but don't implement) a private > constructor. Or... just use a namespace instead of a class? Done.
	27

	28 } // namespace content

	29

	30 #endif // CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UTILS_H_

OLD	NEW