Chromium Code Reviews| Index: sync/protocol/synced_notifications_specifics.proto |
| diff --git a/sync/protocol/preference_specifics.proto b/sync/protocol/synced_notifications_specifics.proto |
| similarity index 67% |
| copy from sync/protocol/preference_specifics.proto |
| copy to sync/protocol/synced_notifications_specifics.proto |
| index 4827c5dc20ceba8b127ce45bb52d0d7ee6f9c0d5..13468c863260f32f28efce029f8ff066255319c4 100644 |
| --- a/sync/protocol/preference_specifics.proto |
| +++ b/sync/protocol/synced_notifications_specifics.proto |
| @@ -2,7 +2,7 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| // |
| -// Sync protocol datatype extension for preferences. |
| +// Sync protocol datatype extension for push notifications.. |
|
akalin
2012/12/12 20:32:05
update this comment
|
| // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change |
| // any fields in this file. |
| @@ -14,9 +14,9 @@ option retain_unknown_fields = true; |
| package sync_pb; |
| -// Properties of preference sync objects. |
| -message PreferenceSpecifics { |
| +// Properties of SyncedNotificationsSpecifics objects. |
| +message SyncedNotificationsSpecifics { |
| + // TODO(petewil): this is placeholder data, make a real one |
| optional string name = 1; |
|
akalin
2012/12/12 20:32:05
can't you just have an empty message? I'd prefer
akalin
2012/12/21 20:27:55
what about this?
|
| optional string value = 2; |
| } |
| - |