Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: sync/protocol/push_notifications_specifics.proto

Issue 11441005: Create a fresh sync datatype for Synced Notifications (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/push_notifications_specifics.proto
diff --git a/sync/protocol/preference_specifics.proto b/sync/protocol/push_notifications_specifics.proto
similarity index 66%
copy from sync/protocol/preference_specifics.proto
copy to sync/protocol/push_notifications_specifics.proto
index 4827c5dc20ceba8b127ce45bb52d0d7ee6f9c0d5..9dd60e2af3243bad6cecb98836567eed4cb16847 100644
--- a/sync/protocol/preference_specifics.proto
+++ b/sync/protocol/push_notifications_specifics.proto
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// Sync protocol datatype extension for preferences.
+// Sync protocol datatype extension for push notifications..
// Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
// any fields in this file.
@@ -14,9 +14,9 @@ option retain_unknown_fields = true;
package sync_pb;
-// Properties of preference sync objects.
-message PreferenceSpecifics {
+// Properties of history delete directive sync objects.
akalin 2012/12/06 23:34:55 change comment
Pete Williamson 2012/12/11 18:05:26 Done.
+message PushNotificationsSpecifics {
+ // TODO: this is leftover from History, replace it with my data
akalin 2012/12/06 23:34:55 hmm what does this mean?
Pete Williamson 2012/12/11 18:05:26 Done. (Comment clarified)
optional string name = 1;
optional string value = 2;
}
-

Powered by Google App Engine
This is Rietveld 408576698