Create a fresh sync datatype for Synced Notifications

sync/protocol/proto_value_conversions.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Keep this file in sync with the .proto files in this directory.
 
 #include "sync/protocol/proto_value_conversions.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 10 matching lines @@
 #include "sync/protocol/extension_setting_specifics.pb.h"
 #include "sync/protocol/extension_specifics.pb.h"
 #include "sync/protocol/history_delete_directive_specifics.pb.h"
 #include "sync/protocol/nigori_specifics.pb.h"
 #include "sync/protocol/password_specifics.pb.h"
 #include "sync/protocol/preference_specifics.pb.h"
 #include "sync/protocol/proto_enum_conversions.h"
 #include "sync/protocol/search_engine_specifics.pb.h"
 #include "sync/protocol/session_specifics.pb.h"
 #include "sync/protocol/sync.pb.h"
+#include "sync/protocol/synced_notifications_specifics.pb.h"
 #include "sync/protocol/theme_specifics.pb.h"
 #include "sync/protocol/typed_url_specifics.pb.h"
 
 namespace syncer {
 
 namespace {
 
 // Basic Type -> Value functions.
 
 StringValue* MakeInt64Value(int64 x) {
@@ skipping 171 matching lines @@
 }
 
 base::DictionaryValue* TimeRangeDirectiveToValue(
     const sync_pb::TimeRangeDirective& proto) {
   DictionaryValue* value = new DictionaryValue();
   SET_INT64(start_time_usec);
   SET_INT64(end_time_usec);
   return value;
 }
 
+// TODO(petewil): I will need new functions here for the SyncedNotifications
+// subtypes.
+
 DictionaryValue* AppNotificationToValue(
     const sync_pb::AppNotification& proto) {
   DictionaryValue* value = new DictionaryValue();
   SET_STR(guid);
   SET_STR(app_id);
   SET_INT64(creation_timestamp_ms);
   SET_STR(title);
   SET_STR(body_text);
   SET_STR(link_url);
   SET_STR(link_text);
@@ skipping 143 matching lines @@
 }
 
 DictionaryValue* PreferenceSpecificsToValue(
     const sync_pb::PreferenceSpecifics& proto) {
   DictionaryValue* value = new DictionaryValue();
   SET_STR(name);
   SET_STR(value);
   return value;
 }
 
+

[Nicolas Zea, 2012/12/12 23:56:00]

nit: remove extra newlines around this method.

+DictionaryValue* SyncedNotificationsSpecificsToValue(
+    const sync_pb::SyncedNotificationsSpecifics& proto) {
+  DictionaryValue* value = new DictionaryValue();
+  // TODO(petewil): Adjust this once we add actual types in protobuf.
+  SET_STR(name);
+  SET_STR(value);
+  return value;
+}
+
+
 DictionaryValue* SearchEngineSpecificsToValue(
     const sync_pb::SearchEngineSpecifics& proto) {
   DictionaryValue* value = new DictionaryValue();
   SET_STR(short_name);
   SET_STR(keyword);
   SET_STR(favicon_url);
   SET_STR(url);
   SET_BOOL(safe_for_autoreplace);
   SET_STR(originating_url);
   SET_INT64(date_created);
@@ skipping 53 matching lines @@
   SET_FIELD(device_info, DeviceInfoSpecificsToValue);
   SET_FIELD(experiments, ExperimentsSpecificsToValue);
   SET_FIELD(extension, ExtensionSpecificsToValue);
   SET_FIELD(extension_setting, ExtensionSettingSpecificsToValue);
   SET_FIELD(history_delete_directive, HistoryDeleteDirectiveSpecificsToValue);
   SET_FIELD(nigori, NigoriSpecificsToValue);
   SET_FIELD(password, PasswordSpecificsToValue);
   SET_FIELD(preference, PreferenceSpecificsToValue);
   SET_FIELD(search_engine, SearchEngineSpecificsToValue);
   SET_FIELD(session, SessionSpecificsToValue);
+  SET_FIELD(synced_notifications, SyncedNotificationsSpecificsToValue);
   SET_FIELD(theme, ThemeSpecificsToValue);
   SET_FIELD(typed_url, TypedUrlSpecificsToValue);
   return value;
 }
 
 namespace {
 
 DictionaryValue* SyncEntityToValue(const sync_pb::SyncEntity& proto,
                                    bool include_specifics) {
   DictionaryValue* value = new DictionaryValue();
@@ skipping 236 matching lines @@
 #undef SET_BYTES
 #undef SET_INT32
 #undef SET_INT64
 #undef SET_INT64_REP
 #undef SET_STR
 #undef SET_STR_REP
 
 #undef SET_FIELD
 
 }  // namespace syncer