Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: src/interface-descriptors.h

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CALL_INTERFACE_DESCRIPTOR_H_ 5 #ifndef V8_CALL_INTERFACE_DESCRIPTOR_H_
6 #define V8_CALL_INTERFACE_DESCRIPTOR_H_ 6 #define V8_CALL_INTERFACE_DESCRIPTOR_H_
7 7
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 13
14 class PlatformInterfaceDescriptor; 14 class PlatformInterfaceDescriptor;
15 15
16 #define INTERFACE_DESCRIPTOR_LIST(V) \ 16 #define INTERFACE_DESCRIPTOR_LIST(V) \
17 V(Load) \ 17 V(Load) \
18 V(Store) \ 18 V(Store) \
19 V(StoreTransition) \ 19 V(StoreTransition) \
20 V(ElementTransitionAndStore) \ 20 V(ElementTransitionAndStore) \
21 V(Instanceof) \ 21 V(Instanceof) \
22 V(VectorLoadICTrampoline) \ 22 V(LoadWithVector) \
23 V(VectorLoadIC) \
24 V(FastNewClosure) \ 23 V(FastNewClosure) \
25 V(FastNewContext) \ 24 V(FastNewContext) \
26 V(ToNumber) \ 25 V(ToNumber) \
27 V(NumberToString) \ 26 V(NumberToString) \
28 V(Typeof) \ 27 V(Typeof) \
29 V(FastCloneShallowArray) \ 28 V(FastCloneShallowArray) \
30 V(FastCloneShallowObject) \ 29 V(FastCloneShallowObject) \
31 V(CreateAllocationSite) \ 30 V(CreateAllocationSite) \
32 V(CreateWeakCell) \ 31 V(CreateWeakCell) \
33 V(CallFunction) \ 32 V(CallFunction) \
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 \ 192 \
194 public: \ 193 public: \
195 static inline CallDescriptors::Key key(); 194 static inline CallDescriptors::Key key();
196 195
197 196
198 // LoadDescriptor is used by all stubs that implement Load/KeyedLoad ICs. 197 // LoadDescriptor is used by all stubs that implement Load/KeyedLoad ICs.
199 class LoadDescriptor : public CallInterfaceDescriptor { 198 class LoadDescriptor : public CallInterfaceDescriptor {
200 public: 199 public:
201 DECLARE_DESCRIPTOR(LoadDescriptor, CallInterfaceDescriptor) 200 DECLARE_DESCRIPTOR(LoadDescriptor, CallInterfaceDescriptor)
202 201
203 enum ParameterIndices { kReceiverIndex, kNameIndex }; 202 enum ParameterIndices { kReceiverIndex, kNameIndex, kSlotIndex };
204 static const Register ReceiverRegister(); 203 static const Register ReceiverRegister();
205 static const Register NameRegister(); 204 static const Register NameRegister();
205 static const Register SlotRegister();
206 }; 206 };
207 207
208 208
209 class StoreDescriptor : public CallInterfaceDescriptor { 209 class StoreDescriptor : public CallInterfaceDescriptor {
210 public: 210 public:
211 DECLARE_DESCRIPTOR(StoreDescriptor, CallInterfaceDescriptor) 211 DECLARE_DESCRIPTOR(StoreDescriptor, CallInterfaceDescriptor)
212 212
213 enum ParameterIndices { 213 enum ParameterIndices {
214 kReceiverIndex, 214 kReceiverIndex,
215 kNameIndex, 215 kNameIndex,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 class InstanceofDescriptor : public CallInterfaceDescriptor { 249 class InstanceofDescriptor : public CallInterfaceDescriptor {
250 public: 250 public:
251 DECLARE_DESCRIPTOR(InstanceofDescriptor, CallInterfaceDescriptor) 251 DECLARE_DESCRIPTOR(InstanceofDescriptor, CallInterfaceDescriptor)
252 252
253 enum ParameterIndices { kLeftIndex, kRightIndex, kParameterCount }; 253 enum ParameterIndices { kLeftIndex, kRightIndex, kParameterCount };
254 static const Register left(); 254 static const Register left();
255 static const Register right(); 255 static const Register right();
256 }; 256 };
257 257
258 258
259 class VectorLoadICTrampolineDescriptor : public LoadDescriptor { 259 class LoadWithVectorDescriptor : public LoadDescriptor {
260 public: 260 public:
261 DECLARE_DESCRIPTOR(VectorLoadICTrampolineDescriptor, LoadDescriptor) 261 DECLARE_DESCRIPTOR(LoadWithVectorDescriptor, LoadDescriptor)
262
263 enum ParameterIndices { kReceiverIndex, kNameIndex, kSlotIndex };
264
265 static const Register SlotRegister();
266 };
267
268
269 class VectorLoadICDescriptor : public VectorLoadICTrampolineDescriptor {
270 public:
271 DECLARE_DESCRIPTOR(VectorLoadICDescriptor, VectorLoadICTrampolineDescriptor)
272 262
273 enum ParameterIndices { 263 enum ParameterIndices {
274 kReceiverIndex, 264 kReceiverIndex,
275 kNameIndex, 265 kNameIndex,
276 kSlotIndex, 266 kSlotIndex,
277 kVectorIndex 267 kVectorIndex
278 }; 268 };
279 269
280 static const Register VectorRegister(); 270 static const Register VectorRegister();
281 }; 271 };
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 } // namespace v8::internal 553 } // namespace v8::internal
564 554
565 555
566 #if V8_TARGET_ARCH_ARM64 556 #if V8_TARGET_ARCH_ARM64
567 #include "src/arm64/interface-descriptors-arm64.h" 557 #include "src/arm64/interface-descriptors-arm64.h"
568 #elif V8_TARGET_ARCH_ARM 558 #elif V8_TARGET_ARCH_ARM
569 #include "src/arm/interface-descriptors-arm.h" 559 #include "src/arm/interface-descriptors-arm.h"
570 #endif 560 #endif
571 561
572 #endif // V8_CALL_INTERFACE_DESCRIPTOR_H_ 562 #endif // V8_CALL_INTERFACE_DESCRIPTOR_H_
OLDNEW
« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698