Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/interface-descriptors.cc

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interface-descriptors.h ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/interface-descriptors.h" 7 #include "src/interface-descriptors.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 INTERFACE_DESCRIPTOR_LIST(DEF_CASE) 54 INTERFACE_DESCRIPTOR_LIST(DEF_CASE)
55 #undef DEF_CASE 55 #undef DEF_CASE
56 case CallDescriptors::NUMBER_OF_DESCRIPTORS: 56 case CallDescriptors::NUMBER_OF_DESCRIPTORS:
57 break; 57 break;
58 } 58 }
59 return ""; 59 return "";
60 } 60 }
61 61
62 62
63 void LoadDescriptor::Initialize(CallInterfaceDescriptorData* data) { 63 void LoadDescriptor::Initialize(CallInterfaceDescriptorData* data) {
64 Register registers[] = {ContextRegister(), ReceiverRegister(), 64 Register registers[] = {ContextRegister(), ReceiverRegister(), NameRegister(),
65 NameRegister()}; 65 SlotRegister()};
66 data->Initialize(arraysize(registers), registers, NULL); 66 Representation representations[] = {
67 Representation::Tagged(), Representation::Tagged(),
68 Representation::Tagged(), Representation::Smi()};
69 data->Initialize(arraysize(registers), registers, representations);
67 } 70 }
68 71
69 72
70 void StoreDescriptor::Initialize(CallInterfaceDescriptorData* data) { 73 void StoreDescriptor::Initialize(CallInterfaceDescriptorData* data) {
71 Register registers[] = {ContextRegister(), ReceiverRegister(), NameRegister(), 74 Register registers[] = {ContextRegister(), ReceiverRegister(), NameRegister(),
72 ValueRegister()}; 75 ValueRegister()};
73 data->Initialize(arraysize(registers), registers, NULL); 76 data->Initialize(arraysize(registers), registers, NULL);
74 } 77 }
75 78
76 79
(...skipping 23 matching lines...) Expand all
100 data->Initialize(arraysize(registers), registers, NULL); 103 data->Initialize(arraysize(registers), registers, NULL);
101 } 104 }
102 105
103 106
104 void MathPowIntegerDescriptor::Initialize(CallInterfaceDescriptorData* data) { 107 void MathPowIntegerDescriptor::Initialize(CallInterfaceDescriptorData* data) {
105 Register registers[] = {ContextRegister(), exponent()}; 108 Register registers[] = {ContextRegister(), exponent()};
106 data->Initialize(arraysize(registers), registers, NULL); 109 data->Initialize(arraysize(registers), registers, NULL);
107 } 110 }
108 111
109 112
110 void VectorLoadICTrampolineDescriptor::Initialize( 113 void LoadWithVectorDescriptor::Initialize(CallInterfaceDescriptorData* data) {
111 CallInterfaceDescriptorData* data) {
112 Register registers[] = {ContextRegister(), ReceiverRegister(), NameRegister(),
113 SlotRegister()};
114 data->Initialize(arraysize(registers), registers, NULL);
115 }
116
117
118 void VectorLoadICDescriptor::Initialize(CallInterfaceDescriptorData* data) {
119 Register registers[] = {ContextRegister(), ReceiverRegister(), NameRegister(), 114 Register registers[] = {ContextRegister(), ReceiverRegister(), NameRegister(),
120 SlotRegister(), VectorRegister()}; 115 SlotRegister(), VectorRegister()};
121 Representation representations[] = { 116 Representation representations[] = {
122 Representation::Tagged(), Representation::Tagged(), 117 Representation::Tagged(), Representation::Tagged(),
123 Representation::Tagged(), Representation::Smi(), 118 Representation::Tagged(), Representation::Smi(),
124 Representation::Tagged()}; 119 Representation::Tagged()};
125 data->Initialize(arraysize(registers), registers, representations); 120 data->Initialize(arraysize(registers), registers, representations);
126 } 121 }
127 122
128 123
(...skipping 18 matching lines...) Expand all
147 } 142 }
148 143
149 144
150 void GrowArrayElementsDescriptor::Initialize( 145 void GrowArrayElementsDescriptor::Initialize(
151 CallInterfaceDescriptorData* data) { 146 CallInterfaceDescriptorData* data) {
152 Register registers[] = {ContextRegister(), ObjectRegister(), KeyRegister()}; 147 Register registers[] = {ContextRegister(), ObjectRegister(), KeyRegister()};
153 data->Initialize(arraysize(registers), registers, NULL); 148 data->Initialize(arraysize(registers), registers, NULL);
154 } 149 }
155 } 150 }
156 } // namespace v8::internal 151 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/interface-descriptors.h ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698