Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/arm64/stub-cache-arm64.cc

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic/ic.h" 10 #include "src/ic/ic.h"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 // Make sure extra and extra2 registers are valid. 109 // Make sure extra and extra2 registers are valid.
110 DCHECK(!extra.is(no_reg)); 110 DCHECK(!extra.is(no_reg));
111 DCHECK(!extra2.is(no_reg)); 111 DCHECK(!extra2.is(no_reg));
112 DCHECK(!extra3.is(no_reg)); 112 DCHECK(!extra3.is(no_reg));
113 113
114 #ifdef DEBUG 114 #ifdef DEBUG
115 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 115 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
116 // extra3 don't conflict with the vector and slot registers, which need 116 // extra3 don't conflict with the vector and slot registers, which need
117 // to be preserved for a handler call or miss. 117 // to be preserved for a handler call or miss.
118 if (IC::ICUseVector(ic_kind)) { 118 if (IC::ICUseVector(ic_kind)) {
119 Register vector = VectorLoadICDescriptor::VectorRegister(); 119 Register vector = LoadWithVectorDescriptor::VectorRegister();
120 Register slot = VectorLoadICDescriptor::SlotRegister(); 120 Register slot = LoadWithVectorDescriptor::SlotRegister();
121 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 121 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
122 } 122 }
123 #endif 123 #endif
124 124
125 Counters* counters = masm->isolate()->counters(); 125 Counters* counters = masm->isolate()->counters();
126 __ IncrementCounter(counters->megamorphic_stub_cache_probes(), 1, extra2, 126 __ IncrementCounter(counters->megamorphic_stub_cache_probes(), 1, extra2,
127 extra3); 127 extra3);
128 128
129 // Check that the receiver isn't a smi. 129 // Check that the receiver isn't a smi.
130 __ JumpIfSmi(receiver, &miss); 130 __ JumpIfSmi(receiver, &miss);
(...skipping 23 matching lines...) Expand all
154 // Cache miss: Fall-through and let caller handle the miss by 154 // Cache miss: Fall-through and let caller handle the miss by
155 // entering the runtime system. 155 // entering the runtime system.
156 __ Bind(&miss); 156 __ Bind(&miss);
157 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 157 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
158 extra3); 158 extra3);
159 } 159 }
160 } 160 }
161 } // namespace v8::internal 161 } // namespace v8::internal
162 162
163 #endif // V8_TARGET_ARCH_ARM64 163 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698