Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic/access-compiler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 10
(...skipping 2109 matching lines...) Expand 10 before | Expand all | Expand 10 after
2120 } 2120 }
2121 } 2121 }
2122 2122
2123 2123
2124 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) { 2124 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
2125 LOperand* context = UseFixed(instr->context(), esi); 2125 LOperand* context = UseFixed(instr->context(), esi);
2126 LOperand* global_object = 2126 LOperand* global_object =
2127 UseFixed(instr->global_object(), LoadDescriptor::ReceiverRegister()); 2127 UseFixed(instr->global_object(), LoadDescriptor::ReceiverRegister());
2128 LOperand* vector = NULL; 2128 LOperand* vector = NULL;
2129 if (instr->HasVectorAndSlot()) { 2129 if (instr->HasVectorAndSlot()) {
2130 vector = FixedTemp(VectorLoadICDescriptor::VectorRegister()); 2130 vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2131 } 2131 }
2132 2132
2133 LLoadGlobalGeneric* result = 2133 LLoadGlobalGeneric* result =
2134 new(zone()) LLoadGlobalGeneric(context, global_object, vector); 2134 new(zone()) LLoadGlobalGeneric(context, global_object, vector);
2135 return MarkAsCall(DefineFixed(result, eax), instr); 2135 return MarkAsCall(DefineFixed(result, eax), instr);
2136 } 2136 }
2137 2137
2138 2138
2139 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) { 2139 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
2140 LOperand* context = UseRegisterAtStart(instr->value()); 2140 LOperand* context = UseRegisterAtStart(instr->value());
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
2174 return DefineAsRegister(new(zone()) LLoadNamedField(obj)); 2174 return DefineAsRegister(new(zone()) LLoadNamedField(obj));
2175 } 2175 }
2176 2176
2177 2177
2178 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) { 2178 LInstruction* LChunkBuilder::DoLoadNamedGeneric(HLoadNamedGeneric* instr) {
2179 LOperand* context = UseFixed(instr->context(), esi); 2179 LOperand* context = UseFixed(instr->context(), esi);
2180 LOperand* object = 2180 LOperand* object =
2181 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister()); 2181 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
2182 LOperand* vector = NULL; 2182 LOperand* vector = NULL;
2183 if (instr->HasVectorAndSlot()) { 2183 if (instr->HasVectorAndSlot()) {
2184 vector = FixedTemp(VectorLoadICDescriptor::VectorRegister()); 2184 vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2185 } 2185 }
2186 LLoadNamedGeneric* result = new(zone()) LLoadNamedGeneric( 2186 LLoadNamedGeneric* result = new(zone()) LLoadNamedGeneric(
2187 context, object, vector); 2187 context, object, vector);
2188 return MarkAsCall(DefineFixed(result, eax), instr); 2188 return MarkAsCall(DefineFixed(result, eax), instr);
2189 } 2189 }
2190 2190
2191 2191
2192 LInstruction* LChunkBuilder::DoLoadFunctionPrototype( 2192 LInstruction* LChunkBuilder::DoLoadFunctionPrototype(
2193 HLoadFunctionPrototype* instr) { 2193 HLoadFunctionPrototype* instr) {
2194 return AssignEnvironment(DefineAsRegister( 2194 return AssignEnvironment(DefineAsRegister(
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
2246 } 2246 }
2247 2247
2248 2248
2249 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) { 2249 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
2250 LOperand* context = UseFixed(instr->context(), esi); 2250 LOperand* context = UseFixed(instr->context(), esi);
2251 LOperand* object = 2251 LOperand* object =
2252 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister()); 2252 UseFixed(instr->object(), LoadDescriptor::ReceiverRegister());
2253 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister()); 2253 LOperand* key = UseFixed(instr->key(), LoadDescriptor::NameRegister());
2254 LOperand* vector = NULL; 2254 LOperand* vector = NULL;
2255 if (instr->HasVectorAndSlot()) { 2255 if (instr->HasVectorAndSlot()) {
2256 vector = FixedTemp(VectorLoadICDescriptor::VectorRegister()); 2256 vector = FixedTemp(LoadWithVectorDescriptor::VectorRegister());
2257 } 2257 }
2258 LLoadKeyedGeneric* result = 2258 LLoadKeyedGeneric* result =
2259 new(zone()) LLoadKeyedGeneric(context, object, key, vector); 2259 new(zone()) LLoadKeyedGeneric(context, object, key, vector);
2260 return MarkAsCall(DefineFixed(result, eax), instr); 2260 return MarkAsCall(DefineFixed(result, eax), instr);
2261 } 2261 }
2262 2262
2263 2263
2264 LOperand* LChunkBuilder::GetStoreKeyedValueOperand(HStoreKeyed* instr) { 2264 LOperand* LChunkBuilder::GetStoreKeyedValueOperand(HStoreKeyed* instr) {
2265 ElementsKind elements_kind = instr->elements_kind(); 2265 ElementsKind elements_kind = instr->elements_kind();
2266 2266
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
2731 LOperand* function = UseRegisterAtStart(instr->function()); 2731 LOperand* function = UseRegisterAtStart(instr->function());
2732 LAllocateBlockContext* result = 2732 LAllocateBlockContext* result =
2733 new(zone()) LAllocateBlockContext(context, function); 2733 new(zone()) LAllocateBlockContext(context, function);
2734 return MarkAsCall(DefineFixed(result, esi), instr); 2734 return MarkAsCall(DefineFixed(result, esi), instr);
2735 } 2735 }
2736 2736
2737 2737
2738 } } // namespace v8::internal 2738 } } // namespace v8::internal
2739 2739
2740 #endif // V8_TARGET_ARCH_IA32 2740 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic/access-compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698