Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1144063002: Cleanup interface descriptors to reflect that vectors are part of loads. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes for test failures. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2852 matching lines...) Expand 10 before | Expand all | Expand 10 after
2863 EmitReturn(instr, false); 2863 EmitReturn(instr, false);
2864 if (no_frame_start != -1) { 2864 if (no_frame_start != -1) {
2865 info()->AddNoFrameRange(no_frame_start, masm_->pc_offset()); 2865 info()->AddNoFrameRange(no_frame_start, masm_->pc_offset());
2866 } 2866 }
2867 } 2867 }
2868 2868
2869 2869
2870 template <class T> 2870 template <class T>
2871 void LCodeGen::EmitVectorLoadICRegisters(T* instr) { 2871 void LCodeGen::EmitVectorLoadICRegisters(T* instr) {
2872 Register vector_register = ToRegister(instr->temp_vector()); 2872 Register vector_register = ToRegister(instr->temp_vector());
2873 Register slot_register = VectorLoadICDescriptor::SlotRegister(); 2873 Register slot_register = LoadWithVectorDescriptor::SlotRegister();
2874 DCHECK(vector_register.is(VectorLoadICDescriptor::VectorRegister())); 2874 DCHECK(vector_register.is(LoadWithVectorDescriptor::VectorRegister()));
2875 DCHECK(slot_register.is(eax)); 2875 DCHECK(slot_register.is(eax));
2876 2876
2877 AllowDeferredHandleDereference vector_structure_check; 2877 AllowDeferredHandleDereference vector_structure_check;
2878 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector(); 2878 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector();
2879 __ mov(vector_register, vector); 2879 __ mov(vector_register, vector);
2880 // No need to allocate this register. 2880 // No need to allocate this register.
2881 FeedbackVectorICSlot slot = instr->hydrogen()->slot(); 2881 FeedbackVectorICSlot slot = instr->hydrogen()->slot();
2882 int index = vector->GetIndex(slot); 2882 int index = vector->GetIndex(slot);
2883 __ mov(slot_register, Immediate(Smi::FromInt(index))); 2883 __ mov(slot_register, Immediate(Smi::FromInt(index)));
2884 } 2884 }
(...skipping 2954 matching lines...) Expand 10 before | Expand all | Expand 10 after
5839 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5839 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5840 RecordSafepoint(Safepoint::kNoLazyDeopt); 5840 RecordSafepoint(Safepoint::kNoLazyDeopt);
5841 } 5841 }
5842 5842
5843 5843
5844 #undef __ 5844 #undef __
5845 5845
5846 } } // namespace v8::internal 5846 } } // namespace v8::internal
5847 5847
5848 #endif // V8_TARGET_ARCH_IA32 5848 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698