Make SharedMemoryDataConsumerHandle thread-safe.

Make SharedMemoryDataConsumerHandle thread-safe.

WebDataConsumerHandle is designed to be thread-safe (See the class comments
for details) and SharedMemoryDataConsumerHandle should keep the thread safety
because it is a WebDataConsumerHandle subclass.

BUG=480746
R=tyoshino

Committed: https://crrev.com/661e87b62f4f466432fbfef8851582f8ead4b25d
Cr-Commit-Position: refs/heads/master@{#332800}

[yhirano, 2015-05-20 07:02:31]

yhirano@chromium.org changed reviewers:
- tyoshino@chromium.org

[yhirano, 2015-05-20 07:47:50]

Patchset #2 (id:20001) has been deleted

[yhirano, 2015-05-20 07:47:58]

Patchset #1 (id:1) has been deleted

[yhirano, 2015-05-20 07:48:16]

yhirano@chromium.org changed reviewers:
+ tyoshino@chromium.org

[yhirano, 2015-05-20 07:48:17]

This CL depends on https://codereview.chromium.org/1118233002/.

[tyoshino (SeeGerritForStatus), 2015-05-28 11:03:58]

lgtm

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
File content/child/shared_memory_data_consumer_handle.h (right):

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
content/child/shared_memory_data_consumer_handle.h:50: virtual void
unregisterClient();
registerClient/unregisterClient should happen in the same thread. Right?

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
File content/child/shared_memory_data_consumer_handle_unittest.cc (right):

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
content/child/shared_memory_data_consumer_handle_unittest.cc:143: size_t
readSize = 0;
chromium style

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
content/child/shared_memory_data_consumer_handle_unittest.cc:147: rv =
handle_->read(&buffer, sizeof(buffer), kNone, &readSize);
arraysize?

[yhirano, 2015-05-28 11:15:20]

Patchset #3 (id:80001) has been deleted

[yhirano, 2015-05-28 11:24:41]

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
File content/child/shared_memory_data_consumer_handle.h (right):

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
content/child/shared_memory_data_consumer_handle.h:50: virtual void
unregisterClient();
On 2015/05/28 11:03:58, tyoshino wrote:
> registerClient/unregisterClient should happen in the same thread. Right?

Yes, as written in WebDataConsumerHandle. Is there any problem?

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
File content/child/shared_memory_data_consumer_handle_unittest.cc (right):

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
content/child/shared_memory_data_consumer_handle_unittest.cc:143: size_t
readSize = 0;
On 2015/05/28 11:03:58, tyoshino wrote:
> chromium style

Done.

https://codereview.chromium.org/1144033002/diff/60001/content/child/shared_me...
content/child/shared_memory_data_consumer_handle_unittest.cc:147: rv =
handle_->read(&buffer, sizeof(buffer), kNone, &readSize);
On 2015/05/28 11:03:58, tyoshino wrote:
> arraysize?

I think sizeof is correct here, because it is the sizeof a region, not the
number of elements. On the other hand, std::fill(&buffer[0],
&buffer[arraysize(buffer)], 0) is correct. I fixed other test cases at
https://codereview.chromium.org/1118233002/#ps140001 (in another CL). Makes
sense?

[yhirano, 2015-06-03 08:35:37]

yhirano@chromium.org changed reviewers:
+ nasko@chromium.org

[yhirano, 2015-06-03 08:35:55]

+nasko@ for OWNER review.

[nasko, 2015-06-03 14:19:34]

nasko@chromium.org changed reviewers:
+ avi@chromium.org

[nasko, 2015-06-03 14:19:34]

This is related to your other CL, so adding avi@ for OWNERS review.

[Avi (use Gerrit), 2015-06-03 15:56:34]

lgtm

[yhirano, 2015-06-04 07:40:15]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-06-04 07:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/1144033002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-04 07:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144033002/120001

[commit-bot: I haz the power, 2015-06-04 08:41:38]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-06-04 08:42:45]

Patchset 4 (id:??) landed as
https://crrev.com/661e87b62f4f466432fbfef8851582f8ead4b25d
Cr-Commit-Position: refs/heads/master@{#332800}