Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4035)

Unified Diff: chrome/test/chromedriver/client/chromedriver.py

Issue 114403005: Adding a LaunchApp command to Chromedriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to latest code Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/client/chromedriver.py
diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py
index dccfde469e9b1905347c0b70618e68bc8e360a1e..10d8429aa0826ba76ad29a87fbf6c34a66e1370d 100644
--- a/chrome/test/chromedriver/client/chromedriver.py
+++ b/chrome/test/chromedriver/client/chromedriver.py
@@ -169,6 +169,9 @@ class ChromeDriver(object):
def Load(self, url):
self.ExecuteCommand(Command.GET, {'url': url})
+ def LaunchApp(self, app_id):
+ self.ExecuteCommand(Command.LAUNCH_APP, {'id': app_id})
chrisgao (Use stgao instead) 2014/01/07 23:36:36 If you do not plan to add an end to end test in ch
bustamante 2014/01/13 21:19:29 Ok, Done.
+
chrisgao (Use stgao instead) 2014/01/07 23:36:36 And what's your plan for the change on the Java cl
bustamante 2014/01/13 21:19:29 It looks like org.openqa.selenium.chrome.ChromeDri
chrisgao (Use stgao instead) 2014/01/15 21:39:56 Sounds good, thanks.
def ExecuteScript(self, script, *args):
converted_args = list(args)
return self.ExecuteCommand(

Powered by Google App Engine
This is Rietveld 408576698