Adding a LaunchApp command to Chromedriver

chrome/test/chromedriver/server/http_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/server/http_handler.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
@@ skipping 100 matching lines @@
                      "session/:sessionId/window_handle",
                      WrapToCommand("GetWindow",
                                    base::Bind(&ExecuteGetCurrentWindowHandle))),
       CommandMapping(
           kGet,
           "session/:sessionId/window_handles",
           WrapToCommand("GetWindows", base::Bind(&ExecuteGetWindowHandles))),
       CommandMapping(kPost,
                      "session/:sessionId/url",
                      WrapToCommand("Navigate", base::Bind(&ExecuteGet))),
+      CommandMapping(kPost,
+                     "session/:sessionId/launch",

[chrisgao (Use stgao instead), 2014/01/07 23:36:36]

As this is a chrome-specific command, we'd better put it after a browser-vendor
name like this session/:sessionId/chromium/launch_app

[bustamante, 2014/01/13 21:19:29]

Sounds good, Done.

+                     WrapToCommand("Navigate", base::Bind(&ExecuteLaunchApp))),

[chrisgao (Use stgao instead), 2014/01/07 23:36:36]

I prefer "LaunchApp" as it is more accurate than "Navigate".

[bustamante, 2014/01/13 21:19:29]

Done.

       CommandMapping(kGet,
                      "session/:sessionId/alert",
                      WrapToCommand("IsAlertOpen",
                                    base::Bind(&ExecuteAlertCommand,
                                               base::Bind(&ExecuteGetAlert)))),
       CommandMapping(
           kPost,
           "session/:sessionId/dismiss_alert",
           WrapToCommand("DismissAlert",
                         base::Bind(&ExecuteAlertCommand,
@@ skipping 586 matching lines @@
         params.SetString(name, path_parts[i]);
     } else if (command_path_parts[i] != path_parts[i]) {
       return false;
     }
   }
   out_params->MergeDictionary(&params);
   return true;
 }
 
 }  // namespace internal