Adding a LaunchApp command to Chromedriver

chrome/test/chromedriver/window_commands.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_CHROMEDRIVER_WINDOW_COMMANDS_H_
 #define CHROME_TEST_CHROMEDRIVER_WINDOW_COMMANDS_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
@@ skipping 21 matching lines @@
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value);
 
 // Loads a URL.
 Status ExecuteGet(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value);
 
+// Launches a Chrome App.
+Status ExecuteLaunchApp(

[chrisgao (Use stgao instead), 2014/01/15 21:39:56]

window_commands.cc/h are for commands that require a target window, like
navigating to a new url in the current target window, finding some element in
the page. If the target window was closed, we will return an error to the client
side. That's why the |WebView* web_view| is passed in and it won't be NULL.

session_commands.cc/h are for commands that require a session only. As long as
the session is not deleted, the command could be run.

"LaunchApp" seems to fall into the category of session_commands.cc/h.
Maybe we'd better move to those two files.

[bustamante, 2014/01/15 23:51:38]

Agree, Done.

+    Session* session,
+    WebView* web_view,
+    const base::DictionaryValue& params,
+    scoped_ptr<base::Value>* value);
+
 // Evaluates a given synchronous script with arguments.
 Status ExecuteExecuteScript(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value);
 
 // Evaluates a given asynchronous script with arguments.
 Status ExecuteExecuteAsyncScript(
     Session* session,
@@ skipping 231 matching lines @@
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value);
 
 Status ExecuteTakeHeapSnapshot(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value);
 
 #endif  // CHROME_TEST_CHROMEDRIVER_WINDOW_COMMANDS_H_