Adding a LaunchApp command to Chromedriver

chrome/test/chromedriver/window_commands.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/window_commands.h"
 
 #include <list>
 #include <string>
 
 #include "base/callback.h"
@@ skipping 229 matching lines @@
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   std::string url;
   if (!params.GetString("url", &url))
     return Status(kUnknownError, "'url' must be a string");
   return web_view->Load(url);
 }
 
+Status ExecuteLaunchApp(
+    Session* session,
+    WebView* web_view,
+    const base::DictionaryValue& params,
+    scoped_ptr<base::Value>* value) {
+  std::string id;
+  if (!params.GetString("id", &id))
+    return Status(kUnknownError, "'id' must be a string");
+
+  if (!session->chrome->GetAsDesktop())
+    return Status(kUnknownError,
+                  "apps can only be launched on desktop platforms");
+
+  AutomationExtension* extension = NULL;
+  Status status =
+      session->chrome->GetAsDesktop()->GetAutomationExtension(&extension);
+  if (status.IsError())
+    return status;
+
+  status = extension->LaunchApp(id);
+  if (status.IsError())
+    return status;
+
+  std::list<std::string> web_view_ids;
+  status = session->chrome->GetWebViewIds(&web_view_ids);
+  if (status.IsError())
+    return status;
+
+  // Switch the active window to the last one opened.
+  session->chrome->ActivateWebView(web_view_ids.back());

[chrisgao (Use stgao instead), 2014/01/15 21:39:56]

The activation might fail. maybe need to check the returned status code.

btw, maybe we don't have to active the app window, because clicking, typing and
others will still work on the app window even it is not activated and focused.

[bustamante, 2014/01/15 23:51:38]

Thanks, per the other comment I removed this code as we don't need to switch
focus anymore.

+  session->window = web_view_ids.back();
+  session->SwitchToTopFrame();
+  session->mouse_position = WebPoint(0, 0);
+
+  return status;
+}
+
 Status ExecuteExecuteScript(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   std::string script;
   if (!params.GetString("script", &script))
     return Status(kUnknownError, "'script' must be a string");
   if (script == ":takeHeapSnapshot") {
     return web_view->TakeHeapSnapshot(value);
@@ skipping 604 matching lines @@
   return status;
 }
 
 Status ExecuteTakeHeapSnapshot(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   return web_view->TakeHeapSnapshot(value);
 }