Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1144023009: Adapt the existing incremental resolution implementation to the new model. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fixes for review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index a47215e27c6d5536f096800e668389fefec22852..7920a6a8fcd4b1a7b13c67bc12d31ed676abaead 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -712,6 +712,11 @@ abstract class AnalysisContext {
List<Source> getSourcesWithFullName(String path);
/**
+ * Invalidates hints in the given [librarySource] and included parts.
+ */
+ void invalidateLibraryHints(Source librarySource);
+
+ /**
* Return `true` if the given [librarySource] is known to be the defining
* compilation unit of a library that can be run on a client (references
* 'dart:html', either directly or indirectly).
@@ -2154,9 +2159,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
return changed;
}
- /**
- * Invalidates hints in the given [librarySource] and included parts.
- */
+ @override
void invalidateLibraryHints(Source librarySource) {
SourceEntry sourceEntry = _cache.get(librarySource);
if (sourceEntry is! DartEntry) {
@@ -4652,8 +4655,8 @@ class AnalysisContextImpl implements InternalAnalysisContext {
// do resolution
Stopwatch perfCounter = new Stopwatch()..start();
PoorMansIncrementalResolver resolver = new PoorMansIncrementalResolver(
- typeProvider, unitSource, dartEntry, oldUnit,
- analysisOptions.incrementalApi, analysisOptions);
+ typeProvider, unitSource, getReadableSourceEntryOrNull(unitSource),
+ null, null, oldUnit, analysisOptions.incrementalApi, analysisOptions);
bool success = resolver.resolve(newCode);
AnalysisEngine.instance.instrumentationService.logPerformance(
AnalysisPerformanceKind.INCREMENTAL, perfCounter,
@@ -9006,8 +9009,8 @@ class IncrementalAnalysisTask extends AnalysisTask {
if (element != null) {
LibraryElement library = element.library;
if (library != null) {
- IncrementalResolver resolver = new IncrementalResolver(
- element, cache.offset, cache.oldLength, cache.newLength);
+ IncrementalResolver resolver = new IncrementalResolver(null, null,
+ null, element, cache.offset, cache.oldLength, cache.newLength);
resolver.resolve(parser.updatedNode);
}
}
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698