Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1144023003: Reduce the appearances of satorux@ from OWNERS files (Closed)

Created:
5 years, 7 months ago by satorux1
Modified:
5 years, 7 months ago
Reviewers:
mtomasz, hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the appearances of satorux@ from OWNERS files Because I no longer work on code in these directories these days. Add hashimoto@ to chrome/browser/chromeos/dbus/OWNERS. BUG=none Committed: https://crrev.com/a0d7e3c8f55596d8b4aab6b5bf7fccf7a2449e59 Cr-Commit-Position: refs/heads/master@{#330709}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sorted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/chromeos/dbus/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/drive/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_widget_private/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/ime/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/drive/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/embedded_test_server/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
satorux1
5 years, 7 months ago (2015-05-20 06:09:57 UTC) #2
mtomasz
lgtm with optional nit https://codereview.chromium.org/1144023003/diff/1/chrome/browser/chromeos/dbus/OWNERS File chrome/browser/chromeos/dbus/OWNERS (right): https://codereview.chromium.org/1144023003/diff/1/chrome/browser/chromeos/dbus/OWNERS#newcode2 chrome/browser/chromeos/dbus/OWNERS:2: hashimoto@chromium.org nit: Shall we sort?
5 years, 7 months ago (2015-05-20 06:22:36 UTC) #3
hashimoto
lgtm
5 years, 7 months ago (2015-05-20 07:07:42 UTC) #4
satorux1
https://codereview.chromium.org/1144023003/diff/1/chrome/browser/chromeos/dbus/OWNERS File chrome/browser/chromeos/dbus/OWNERS (right): https://codereview.chromium.org/1144023003/diff/1/chrome/browser/chromeos/dbus/OWNERS#newcode2 chrome/browser/chromeos/dbus/OWNERS:2: hashimoto@chromium.org On 2015/05/20 06:22:36, mtomasz wrote: > nit: Shall ...
5 years, 7 months ago (2015-05-20 07:10:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144023003/20001
5 years, 7 months ago (2015-05-20 07:10:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 07:18:26 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 07:19:16 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a0d7e3c8f55596d8b4aab6b5bf7fccf7a2449e59
Cr-Commit-Position: refs/heads/master@{#330709}

Powered by Google App Engine
This is Rietveld 408576698