Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1144013007: Remove GrContext from GrClipMaskCache (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
M src/gpu/GrClipMaskCache.h View 7 chunks +7 lines, -16 lines 0 comments Download
M src/gpu/GrClipMaskCache.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 4 chunks +4 lines, -11 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +4 lines, -11 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +11 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ClipCacheTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
5 years, 6 months ago (2015-05-29 15:40:10 UTC) #2
joshualitt
On 2015/05/29 15:40:10, bsalomon wrote: lgtm
5 years, 6 months ago (2015-05-29 15:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144013007/20001
5 years, 6 months ago (2015-05-29 15:51:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1324)
5 years, 6 months ago (2015-05-29 15:52:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144013007/40001
5 years, 6 months ago (2015-05-29 16:32:57 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 16:46:02 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/edd77a112dedd82dae78ccdd7177531569c4e6f7

Powered by Google App Engine
This is Rietveld 408576698