Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5664)

Unified Diff: chrome/browser/upgrade_detector.cc

Issue 11440020: Add an outdated upgrade bubble view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some more self-CR cleanups Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/upgrade_detector.cc
diff --git a/chrome/browser/upgrade_detector.cc b/chrome/browser/upgrade_detector.cc
index acb742f35c10eae16f887074d92f789e716653ca..4716963009ca5fb042c1c9cbc43c7e4567e61b6e 100644
--- a/chrome/browser/upgrade_detector.cc
+++ b/chrome/browser/upgrade_detector.cc
@@ -61,7 +61,7 @@ int UpgradeDetector::GetIconResourceID(UpgradeNotificationIconType type) {
}
UpgradeDetector::UpgradeDetector()
- : is_critical_upgrade_(false),
+ : upgrade_required_(UPGRADE_REQUIRED_NONE),
critical_update_acknowledged_(false),
upgrade_notification_stage_(UPGRADE_ANNOYANCE_NONE),
notify_upgrade_(false) {
@@ -83,13 +83,25 @@ void UpgradeDetector::NotifyUpgradeRecommended() {
content::Source<UpgradeDetector>(this),
content::NotificationService::NoDetails());
- if (is_critical_upgrade_) {
- int idle_timer = UseTestingIntervals() ?
- kIdleRepeatingTimerWait :
- kIdleRepeatingTimerWait * 60; // To minutes.
- idle_check_timer_.Start(FROM_HERE,
- base::TimeDelta::FromSeconds(idle_timer),
- this, &UpgradeDetector::CheckIdle);
+ switch (upgrade_required_) {
+ case UPGRADE_REQUIRED_OUTDATED: {
+ content::NotificationService::current()->Notify(
+ chrome::NOTIFICATION_OUTDATED_INSTALL,
+ content::Source<UpgradeDetector>(this),
+ content::NotificationService::NoDetails());
+ break;
+ }
+ case UPGRADE_REQUIRED_CRITICAL: {
+ int idle_timer = UseTestingIntervals() ?
+ kIdleRepeatingTimerWait :
+ kIdleRepeatingTimerWait * 60; // To minutes.
+ idle_check_timer_.Start(FROM_HERE,
+ base::TimeDelta::FromSeconds(idle_timer),
+ this, &UpgradeDetector::CheckIdle);
+ break;
+ }
+ default:
+ break;
}
}

Powered by Google App Engine
This is Rietveld 408576698