Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chrome/browser/upgrade_detector_impl.cc

Issue 11440020: Add an outdated upgrade bubble view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed CR comments... Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/upgrade_detector_impl.cc
diff --git a/chrome/browser/upgrade_detector_impl.cc b/chrome/browser/upgrade_detector_impl.cc
index 570275e391ba59c8452c3de6d6861f7f4ead8e04..298012cc262ba710ec96ff2a62d71672f68e5c3e 100644
--- a/chrome/browser/upgrade_detector_impl.cc
+++ b/chrome/browser/upgrade_detector_impl.cc
@@ -16,13 +16,17 @@
#include "base/string_util.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
+#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/installer/util/browser_distribution.h"
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "ui/base/resource/resource_bundle.h"
#if defined(OS_WIN)
+#include "chrome/installer/util/google_update_settings.h"
#include "chrome/installer/util/install_util.h"
#elif defined(OS_MACOSX)
#include "chrome/browser/mac/keystone_glue.h"
@@ -150,6 +154,10 @@ void DetectUpgradeTask(const base::Closure& upgrade_detected_task,
}
}
+void DetectOutdatedTask() {
+
+}
+
Finnur 2013/01/23 10:39:17 remove?
MAD 2013/01/23 20:57:59 Done.
} // namespace
UpgradeDetectorImpl::UpgradeDetectorImpl()
@@ -175,6 +183,11 @@ UpgradeDetectorImpl::UpgradeDetectorImpl()
this, &UpgradeDetectorImpl::CheckForUpgrade);
}
#endif
+#if defined(OS_WIN)
+
+#else
+
+#endif
Finnur 2013/01/23 10:39:17 remove?
MAD 2013/01/23 20:57:59 Done.
}
UpgradeDetectorImpl::~UpgradeDetectorImpl() {
@@ -268,6 +281,19 @@ void UpgradeDetectorImpl::NotifyOnUpgrade() {
NotifyUpgradeRecommended();
}
+void UpgradeDetectorImpl::NotifyOutdatedChromeVersio() {
+ // Stop the recurring timer (that is checking for changes).
+ detect_upgrade_timer_.Stop();
+ set_upgrade_notification_stage(UPGRADE_ANNOYANCE_CRITICAL);
+
+ content::NotificationService::current()->Notify(
+ chrome::NOTIFICATION_OUTDATED_INSTALL,
+ content::Source<UpgradeDetector>(this),
+ content::NotificationService::NoDetails());
+
+ NotifyUpgradeRecommended();
+}
+
// static
UpgradeDetectorImpl* UpgradeDetectorImpl::GetInstance() {
return Singleton<UpgradeDetectorImpl>::get();

Powered by Google App Engine
This is Rietveld 408576698