Add an outdated upgrade bubble view.

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 11ba1beba6acfc153ab73f16e722f8f9c4fd9c76..3018bf63ff477c46a49c927f8a7aa6d97bdd5bf2 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -52,6 +52,7 @@
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
+#include "chrome/browser/upgrade_detector.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
@@ -84,6 +85,8 @@
 
 namespace {
 const char kOsOverrideForTabletSite[] = "Linux; Android 4.0.3";
+
+const char kDownloadChromeUrl[] = "https://www.google.com/chrome";
 }
 
 using content::NavigationController;
@@ -912,9 +915,20 @@ void ShowAvatarMenu(Browser* browser) {
   browser->window()->ShowAvatarBubbleFromAvatarButton();
 }
 
+void NavigateToChromeInstallPage(Browser* browser) {
+  content::RecordAction(
+      content::UserMetricsAction("OutdatedUpgradeReinstall"));

[Finnur, 2013/01/24 10:13:33]

This is a general purpose browser commands file, so it feels weird to send out a
OutdatedUpgradeReinstall. What if some other code starts using this function?

[MAD, 2013/01/24 17:29:35]

I thought actually that it might be useful to have it there in case some other
use cases may need it, but I think you are right, I'll inline it below... Unless
you prefer we move this somewhere else...

[Finnur, 2013/01/25 11:39:22]

I was thinking either making the UMA metric more general (because this function
is in a general location and might be needed for uses other than outdated
upgrades) or move the UMA metric call to 'outdated upgrade'-code that uses it.

But I guess this change is OK too.

+  chrome::AddSelectedTabWithURL(
+      browser, GURL(kDownloadChromeUrl), content::PAGE_TRANSITION_LINK);
+}
+
 void OpenUpdateChromeDialog(Browser* browser) {
-  content::RecordAction(UserMetricsAction("UpdateChrome"));
-  browser->window()->ShowUpdateChromeDialog();
+  if (UpgradeDetector::GetInstance()->IsOutdatedInstall()) {
+    NavigateToChromeInstallPage(browser);
+  } else {
+    content::RecordAction(UserMetricsAction("UpdateChrome"));
+    browser->window()->ShowUpdateChromeDialog();
+  }
 }
 
 void ToggleSpeechInput(Browser* browser) {