Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 11440020: Add an outdated upgrade bubble view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Exclude Chrome OS correctly Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 282597d3f1ffe7e23c47cb4cf0aa327faa8c2260..62a29b52a95787f99ae6c0339ae24687bb3d2b06 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -52,6 +52,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
#include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
+#include "chrome/browser/upgrade_detector.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
@@ -84,6 +85,9 @@
namespace {
const char kOsOverrideForTabletSite[] = "Linux; Android 4.0.3";
+
+const char kDownloadChromeUrl[] = "https://www.google.com/chrome/?&brand=CHWL"
+ "&utm_campaign=en&utm_source=en-et-na-us-chrome-bubble&utm_medium=et";
}
using content::NavigationController;
@@ -909,8 +913,15 @@ void ShowAvatarMenu(Browser* browser) {
}
void OpenUpdateChromeDialog(Browser* browser) {
- content::RecordAction(UserMetricsAction("UpdateChrome"));
- browser->window()->ShowUpdateChromeDialog();
+ if (UpgradeDetector::GetInstance()->is_outdated_install()) {
+ content::RecordAction(
+ content::UserMetricsAction("OutdatedUpgradeReinstall"));
+ AddSelectedTabWithURL(
+ browser, GURL(kDownloadChromeUrl), content::PAGE_TRANSITION_LINK);
+ } else {
+ content::RecordAction(UserMetricsAction("UpdateChrome"));
+ browser->window()->ShowUpdateChromeDialog();
+ }
}
void ToggleSpeechInput(Browser* browser) {

Powered by Google App Engine
This is Rietveld 408576698