Add an outdated upgrade bubble view.

chrome/browser/upgrade_detector.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UPGRADE_DETECTOR_H_
 #define CHROME_BROWSER_UPGRADE_DETECTOR_H_
 
 #include "base/timer.h"
 #include "chrome/browser/idle.h"
 #include "ui/gfx/image/image.h"
@@ skipping 31 matching lines @@
   // Returns the singleton implementation instance.
   static UpgradeDetector* GetInstance();
 
   virtual ~UpgradeDetector();
 
   static void RegisterPrefs(PrefServiceSimple* prefs);
 
   // Whether the user should be notified about an upgrade.
   bool notify_upgrade() const { return notify_upgrade_; }
 
-  // Whether the upgrade is a critical upgrade (such as a zero-day update).
-  bool is_critical_update() const { return is_critical_upgrade_; }
+  // Whether the upgrade is due to Chrome being outdated.

[Finnur, 2013/02/01 17:09:15]

nit: I would probably inject the word 'recommendation' between 'upgrade' and
'is'.

[MAD, 2013/02/02 03:55:34]

Done.

+  bool IsOutdatedInstall() const {

[Finnur, 2013/02/01 17:09:15]

But... this function is still simple, no? Why change it to Title-case?

[MAD, 2013/02/02 03:55:34]

Done.
I thought it was only for accessors, i.e., getting the value of a data member,
but you're right, it kind of is an accessor to a specific state of a data
member, good enough... :-)

+    return upgrade_required_ == UPGRADE_REQUIRED_OUTDATED;
+  }
 
   // Notifify this object that the user has acknowledged the critical update
   // so we don't need to complain about it for now.
   void acknowledge_critical_update() {
     critical_update_acknowledged_ = true;
   }
 
   // Whether the user has acknowledged the critical update.
   bool critical_update_acknowledged() const {
     return critical_update_acknowledged_;
@@ skipping 21 matching lines @@
   // Sends out UPGRADE_DETECTED notification and record upgrade_detected_time_.
   void NotifyUpgradeDetected();
 
   // Sends out UPGRADE_RECOMMENDED notification and set notify_upgrade_.
   void NotifyUpgradeRecommended();
 
   void set_upgrade_notification_stage(UpgradeNotificationAnnoyanceLevel stage) {
     upgrade_notification_stage_ = stage;
   }
 
-  // True if a critical update to Chrome has been installed, such as a zero-day
-  // fix.
-  bool is_critical_upgrade_;
+  enum UpgradeRequired {

[Finnur, 2013/02/01 17:09:15]

nit: Required is a bit of a strong word. We only require updates for critical
updates, which happen mostly behinds the scene so the user shouldn't notice
them. I thought about calling this UpgradeAvailable and the enum values
UPGRADE_AVAILABLE_* and the last one UPGRADE_NEEDED_OUTDATED_INSTALL, or
something. 

Use as a suggestion if you feel it is an improvement. But feel free to ignore. 

[MAD, 2013/02/02 03:55:34]

Done.

+    // If no update is available and current install is recent enough.
+    UPGRADE_REQUIRED_NONE,
+    // If a regular update is available.
+    UPGRADE_REQUIRED_REGULAR,
+    // If a critical update to Chrome has been installed, such as a zero-day
+    // fix.
+    UPGRADE_REQUIRED_CRITICAL,
+    // If no update to Chrome has been installed for more than the allowed time.

[Finnur, 2013/02/01 17:09:15]

nit: s/allowed/recommended/

[MAD, 2013/02/02 03:55:34]

Done.

+    UPGRADE_REQUIRED_OUTDATED,
+  } upgrade_required_;
 
   // Whether the user has acknowledged the critical update.
   bool critical_update_acknowledged_;
 
  private:
   // Initiates an Idle check. See IdleCallback below.
   void CheckIdle();
 
   // The callback for the IdleCheck. Tells us whether Chrome has received any
   // input events since the specified time.
   void IdleCallback(IdleState state);
 
   // When the upgrade was detected.
   base::Time upgrade_detected_time_;
 
   // A timer to check to see if we've been idle for long enough to show the
-  // critical warning. Should only be set if |is_critical_upgrade_| is true.
+  // critical warning. Should only be set if |upgrade_required_| is
+  // UPGRADE_REQUIRED_CRITICAL.
   base::RepeatingTimer<UpgradeDetector> idle_check_timer_;
 
   // The stage at which the annoyance level for upgrade notifications is at.
   UpgradeNotificationAnnoyanceLevel upgrade_notification_stage_;
 
   // Whether we have waited long enough after detecting an upgrade (to see
   // is we should start nagging about upgrading).
   bool notify_upgrade_;
 
   DISALLOW_COPY_AND_ASSIGN(UpgradeDetector);
 };
 
 #endif  // CHROME_BROWSER_UPGRADE_DETECTOR_H_