Add an outdated upgrade bubble view.

chrome/browser/ui/views/upgrade_bubble_view.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_UPGRADE_BUBBLE_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_UPGRADE_BUBBLE_VIEW_H_
+
+#include "ui/views/bubble/bubble_delegate.h"
+#include "ui/views/controls/button/button.h"
+
+namespace views {
+class TextButton;
+}
+
+class Browser;
+
+// UpgradeBubbleView is a view intended to be used as the content of a
+// Bubble. UpgradeBubbleView provides views for warning the user that an
+// upgrade is long overdue. Don't create a UpgradeBubbleView directly,

[Finnur, 2012/12/06 19:53:16]

nit: Perhaps reword:
UpgradeBubbleView is a view that warns the user that an upgrade is long overdue.
It is intended to be used as the content of a bubble anchored off of the Chrome
toolbar.

[MAD, 2013/01/22 15:18:29]

Done.

+// instead use the static Show method.
+class UpgradeBubbleView : public views::BubbleDelegateView,

[Finnur, 2012/12/06 19:53:16]

Hmm... I find this name a little bit too general as the bubble is more specific
than that and there is potential for people to confuse this with the
CriticalUpgrade bubble view. Are there other names we could use, that are more
specific? Such as AutoUpgradeErrorBubbleView (or something to that effect)? If
you change it, remember to change the comment above, too.

[MAD, 2013/01/22 15:18:29]

Done.

+                          public views::ButtonListener {
+ public:
+  static void ShowBubble(views::View* anchor_view, Browser* browser);
+
+  virtual ~UpgradeBubbleView();

[Finnur, 2012/12/06 19:53:16]

I forget... Didn't we have a rule of thumb to move destructors to be private for
things we didn't want people to construct directly?

[MAD, 2013/01/22 15:18:29]

Done.


I just followed what was done with the bookmark bubble view, I guess I should
have started with the critical update one instead...

+
+  // views::BubbleDelegateView method.
+  virtual views::View* GetInitiallyFocusedView() OVERRIDE;
+
+  // views::WidgetDelegate method.
+  virtual void WindowClosing() OVERRIDE;
+
+  // views::View method.
+  virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE;
+
+ protected:
+  // views::BubbleDelegateView method.
+  virtual void Init() OVERRIDE;

[Finnur, 2012/12/06 19:53:16]

Why protected?

[MAD, 2013/01/22 15:18:29]

Done. Again, as is done in bookmark bubble view, should I fix it there too?

[Finnur, 2013/01/23 10:39:17]

So... I would probably contact the owner of that view and ask if you should fix
the issues that stem from that class being the basis of this class. Maybe there
is a reason. Maybe it is just an error and should be fixed in both places.

On 2013/01/22 15:18:29, MAD wrote:

+
+ private:
+  static bool IsShowing();
+
+  // Creates a UpgradeBubbleView.
+  UpgradeBubbleView(views::View* anchor_view, Browser* browser);

[Finnur, 2012/12/06 19:53:16]

Constructor before static methods, according to style guide:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar...

[MAD, 2013/01/22 15:18:29]

Done.

+
+  // Overridden from views::ButtonListener:

[Finnur, 2012/12/06 19:53:16]

nit: You've used 'foo method.' convention above, so I suggest sticking to that.

[MAD, 2013/01/22 15:18:29]

Done.

+  // Closes the bubble or opens the download Chrome URL.
+  virtual void ButtonPressed(views::Button* sender,
+                             const ui::Event& event) OVERRIDE;
+
+  // Handle the message when the user presses a button.
+  void HandleButtonPressed(views::Button* sender);
+
+  // The upgrade bubble, if we're showing one.
+  static UpgradeBubbleView* upgrade_bubble_;
+
+  // Button to reinstall now.
+  views::TextButton* reinstall_button_;
+
+  // Button to be reminded later.

[Finnur, 2012/12/06 19:53:16]

nit: What does the button need to be reminded of? :) Suggest rewording. Same
goes for the reinstall_button_ above.

[MAD, 2013/01/22 15:18:29]

Done.

+  views::TextButton* later_button_;
+
+  // The browser to use for opening the download Chrome URL.

[Finnur, 2012/12/06 19:53:16]

nit: Suggest capitalize d in Download

[MAD, 2013/01/22 15:18:29]

Done.

+  Browser* browser_;
+
+  DISALLOW_COPY_AND_ASSIGN(UpgradeBubbleView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_UPGRADE_BUBBLE_VIEW_H_