Add an outdated upgrade bubble view.

chrome/browser/upgrade_detector.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UPGRADE_DETECTOR_H_
 #define CHROME_BROWSER_UPGRADE_DETECTOR_H_
 
 #include "base/timer.h"
 #include "chrome/browser/idle.h"
 #include "ui/gfx/image/image.h"
@@ skipping 34 matching lines @@
   virtual ~UpgradeDetector();
 
   static void RegisterPrefs(PrefServiceSimple* prefs);
 
   // Whether the user should be notified about an upgrade.
   bool notify_upgrade() const { return notify_upgrade_; }
 
   // Whether the upgrade is a critical upgrade (such as a zero-day update).
   bool is_critical_update() const { return is_critical_upgrade_; }
 
+  // Whether the upgrade is a outdated Chrome (no updates for too long).
+  bool IsOutdatedInstall() const {

[Finnur, 2013/01/24 10:13:33]

Are you sure we consider one && and one ! so heavyweight that we forgo the unix
hacker style (is_outdated_install())?

[MAD, 2013/01/24 17:29:35]

I thought hacker style was just when we return the variable as is, but you are
right, again :-), the coding style just says simple. Takk... again... :-)

+    // Critical upgrade have precedence over outdated because it means we
+    // successfully installed a critical upgrade, so no need to reinstall.
+    return is_outdated_install_ && !is_critical_upgrade_;
+  }
+
   // Notifify this object that the user has acknowledged the critical update
   // so we don't need to complain about it for now.
   void acknowledge_critical_update() {
     critical_update_acknowledged_ = true;
   }
 
   // Whether the user has acknowledged the critical update.
   bool critical_update_acknowledged() const {
     return critical_update_acknowledged_;
   }
@@ skipping 24 matching lines @@
   void NotifyUpgradeRecommended();
 
   void set_upgrade_notification_stage(UpgradeNotificationAnnoyanceLevel stage) {
     upgrade_notification_stage_ = stage;
   }
 
   // True if a critical update to Chrome has been installed, such as a zero-day
   // fix.
   bool is_critical_upgrade_;
 
+  // True if no update to Chrome has been installed for more than the allowed
+  // time, which means updating keeps failing, so a reinstall can be suggested.
+  bool is_outdated_install_;
+
   // Whether the user has acknowledged the critical update.
   bool critical_update_acknowledged_;
 
  private:
   // Initiates an Idle check. See IdleCallback below.
   void CheckIdle();
 
   // The callback for the IdleCheck. Tells us whether Chrome has received any
   // input events since the specified time.
   void IdleCallback(IdleState state);
 
   // When the upgrade was detected.
   base::Time upgrade_detected_time_;
 
   // A timer to check to see if we've been idle for long enough to show the
-  // critical warning. Should only be set if |is_critical_upgrade_| is true.
+  // critical warning. Should only be set if |is_critical_upgrade_| or
+  // |is_outdated_install_| is true.
   base::RepeatingTimer<UpgradeDetector> idle_check_timer_;
 
   // The stage at which the annoyance level for upgrade notifications is at.
   UpgradeNotificationAnnoyanceLevel upgrade_notification_stage_;
 
   // Whether we have waited long enough after detecting an upgrade (to see
   // is we should start nagging about upgrading).
   bool notify_upgrade_;
 
   DISALLOW_COPY_AND_ASSIGN(UpgradeDetector);
 };
 
 #endif  // CHROME_BROWSER_UPGRADE_DETECTOR_H_