Add an outdated upgrade bubble view.

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
@@ skipping 34 matching lines @@
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
 #include "chrome/browser/ui/omnibox/location_bar.h"
 #include "chrome/browser/ui/search/search.h"
 #include "chrome/browser/ui/search/search_model.h"
 #include "chrome/browser/ui/status_bubble.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
+#include "chrome/browser/upgrade_detector.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 12 matching lines @@
 #include "ui/base/cocoa/find_pasteboard.h"
 #endif
 
 #if defined(OS_WIN)
 #include "chrome/browser/ui/metro_pin_tab_helper_win.h"
 #include "win8/util/win8_util.h"
 #endif
 
 namespace {
 const char kOsOverrideForTabletSite[] = "Linux; Android 4.0.3";
+
+const char kDownloadChromeUrl[] = "https://www.google.com/chrome";
 }
 
 using content::NavigationController;
 using content::NavigationEntry;
 using content::OpenURLParams;
 using content::Referrer;
 using content::SSLStatus;
 using content::UserMetricsAction;
 using content::WebContents;
 
@@ skipping 808 matching lines @@
 
 void ShowAppMenu(Browser* browser) {
   // We record the user metric for this event in WrenchMenu::RunMenu.
   browser->window()->ShowAppMenu();
 }
 
 void ShowAvatarMenu(Browser* browser) {
   browser->window()->ShowAvatarBubbleFromAvatarButton();
 }
 
+void NavigateToChromeInstallPage(Browser* browser) {
+  content::RecordAction(
+      content::UserMetricsAction("OutdatedUpgradeReinstall"));

[Finnur, 2013/01/24 10:13:33]

This is a general purpose browser commands file, so it feels weird to send out a
OutdatedUpgradeReinstall. What if some other code starts using this function?

[MAD, 2013/01/24 17:29:35]

I thought actually that it might be useful to have it there in case some other
use cases may need it, but I think you are right, I'll inline it below... Unless
you prefer we move this somewhere else...

[Finnur, 2013/01/25 11:39:22]

I was thinking either making the UMA metric more general (because this function
is in a general location and might be needed for uses other than outdated
upgrades) or move the UMA metric call to 'outdated upgrade'-code that uses it.

But I guess this change is OK too.

+  chrome::AddSelectedTabWithURL(
+      browser, GURL(kDownloadChromeUrl), content::PAGE_TRANSITION_LINK);
+}
+
 void OpenUpdateChromeDialog(Browser* browser) {
-  content::RecordAction(UserMetricsAction("UpdateChrome"));
-  browser->window()->ShowUpdateChromeDialog();
+  if (UpgradeDetector::GetInstance()->IsOutdatedInstall()) {
+    NavigateToChromeInstallPage(browser);
+  } else {
+    content::RecordAction(UserMetricsAction("UpdateChrome"));
+    browser->window()->ShowUpdateChromeDialog();
+  }
 }
 
 void ToggleSpeechInput(Browser* browser) {
   browser->tab_strip_model()->GetActiveWebContents()->
       GetRenderViewHost()->ToggleSpeechInput();
 }
 
 bool CanRequestTabletSite(WebContents* current_tab) {
   if (!current_tab)
     return false;
@@ skipping 161 matching lines @@
       Browser::CreateParams::CreateForApp(
           Browser::TYPE_POPUP, app_name, gfx::Rect(), browser->profile()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 
 }  // namespace chrome