Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1143993003: Use shared container to manage imports/exports. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use shared container to manage imports/exports. Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521} Committed: https://crrev.com/e56585077bdc3f6ce9990c86c00858c62eae790d Cr-Commit-Position: refs/heads/master@{#28533}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Patch Set 3 : fixed test for no-snap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -308 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/array.js View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M src/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/arraybuffer.js View 2 chunks +17 lines, -5 lines 0 comments Download
M src/bootstrapper.cc View 1 10 chunks +37 lines, -39 lines 0 comments Download
M src/collection.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/collection-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/date.js View 5 chunks +14 lines, -6 lines 0 comments Download
M src/generator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-array.js View 1 chunk +19 lines, -8 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-spread.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/i18n.js View 48 chunks +94 lines, -85 lines 0 comments Download
M src/iterator-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 3 chunks +11 lines, -3 lines 0 comments Download
M src/math.js View 1 2 3 chunks +12 lines, -14 lines 0 comments Download
M src/messages.js View 7 chunks +18 lines, -8 lines 0 comments Download
M src/object-observe.js View 2 chunks +2 lines, -2 lines 0 comments Download
A src/prologue.js View 1 chunk +57 lines, -0 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 6 chunks +22 lines, -13 lines 0 comments Download
M src/string-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M src/symbol.js View 1 chunk +1 line, -1 line 0 comments Download
M src/templates.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 2 8 chunks +24 lines, -13 lines 0 comments Download
M src/typedarray.js View 2 chunks +19 lines, -5 lines 0 comments Download
M src/uri.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M src/weak-collection.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +38 lines, -26 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/regress/regress-1878.js View 1 chunk +0 lines, -44 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
5 years, 7 months ago (2015-05-20 12:15:40 UTC) #1
Jakob Kummerow
LGTM with a comment. https://codereview.chromium.org/1143993003/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1143993003/diff/1/src/bootstrapper.cc#newcode1524 src/bootstrapper.cc:1524: isolate->factory()->NewStringFromAsciiChecked("PostNatives"); Did you mean s/"PostNatives"/name/ ...
5 years, 7 months ago (2015-05-20 13:23:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143993003/20001
5 years, 7 months ago (2015-05-20 14:33:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 14:59:08 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521}
5 years, 7 months ago (2015-05-20 14:59:22 UTC) #7
Jakob Kummerow
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1144163002/ by jkummerow@chromium.org. ...
5 years, 7 months ago (2015-05-20 15:59:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143993003/40001
5 years, 7 months ago (2015-05-21 05:40:50 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 06:15:42 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 06:16:00 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e56585077bdc3f6ce9990c86c00858c62eae790d
Cr-Commit-Position: refs/heads/master@{#28533}

Powered by Google App Engine
This is Rietveld 408576698